Skip to content

Conversation

@AustinMroz
Copy link
Collaborator

@AustinMroz AustinMroz commented Oct 17, 2025

Adds a new keybind to attempt to toggle the promotion state of the currently hovered widget

Adds a keybind to open the subgraph configuration panel

Neither of these options are given a default binding.

Cleans up some incorrect version and icon information that was forgotten about.

┆Issue is synchronized with this Notion page by Unito

Adds a new keybind to attempt to toggle the promotion state of the
currently hovered widget

Adds a keybind to open the subgraph configuration panel

Neither of these options are given a default binding.

Cleans up some incorrect version and icon information that was forgotten
about.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 17, 2025
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 10/17/2025, 09:30:42 PM UTC

📈 Summary

  • Total Tests: 497
  • Passed: 463 ✅
  • Failed: 1 ❌
  • Flaky: 3 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 454 / ❌ 1 / ⚠️ 3 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/17/2025, 09:14:42 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@benceruleanlu benceruleanlu self-requested a review October 17, 2025 19:02
Fix incorrect icon name

Use a proper error toast with translation and lifetime one promotion
outside subgraph.

Swap to graph_mouse over canvas_mouse
benceruleanlu
benceruleanlu previously approved these changes Oct 17, 2025
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-byrne christian-byrne merged commit a0d9cc7 into main Oct 17, 2025
33 of 34 checks passed
@christian-byrne christian-byrne deleted the austin/subgraph-widget-keybinds branch October 17, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:hotkeys area:subgraph size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants