Skip to content

Conversation

@AustinMroz
Copy link
Collaborator

@AustinMroz AustinMroz commented Oct 18, 2025

image

Design docs show icon as being reversed in litegraph mode. If needed, fixing this is basically just removing a negative sign.

LiteGraph implementation was not as clean as I hoped. I can spend some more time divining some non-magic constants, and mayybe resolve the svg data from css styles if desired.

Resolves #4647
Resolves #6107

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 18, 2025
@github-actions
Copy link

github-actions bot commented Oct 18, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 10/18/2025, 05:04:20 AM UTC

📈 Summary

  • Total Tests: 498
  • Passed: 465 ✅
  • Failed: 1 ❌
  • Flaky: 2 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 456 / ❌ 1 / ⚠️ 2 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Oct 18, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/18/2025, 04:50:53 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

Bundle Size Report

App Entry Points

Main application bundles

File Size Gzip Brotli
assets/index-BbCPb2O9.js
assets/index-C9rtnnM1.js
assets/index-Dxw6d55T.js 9.67 MB 1.99 MB 1.43 MB
assets/index-MgVpi94-.js 2.02 MB 381 kB 296 kB
assets/index-PESgPnbc.js 507 B 292 B 249 B

Category Total: 11.7 MB

Core Views

Major application views and screens

File Size Gzip Brotli
assets/GraphView-D8od12x4.js 713 kB 139 kB 108 kB
assets/GraphView-pnqOY9rk.js
assets/UserSelectView-BvzxtqjF.js 7.99 kB 2.4 kB 2.1 kB
assets/UserSelectView-DWvD5VNj.js

Category Total: 721 kB

UI Panels

Settings and configuration panels

File Size Gzip Brotli
assets/AboutPanel-BmgJ3RUl.js 10.1 kB 2.58 kB 2.27 kB
assets/AboutPanel-Cjbm7rWi.js
assets/CreditsPanel-Onm11UFv.js 21.9 kB 5.21 kB 4.54 kB
assets/CreditsPanel-VH3aukMC.js
assets/ExtensionPanel-BEh8VaTh.js
assets/ExtensionPanel-DbpMns0L.js 11.9 kB 2.74 kB 2.4 kB
assets/KeybindingPanel-iZYgTzSz.js 15.1 kB 3.68 kB 3.24 kB
assets/KeybindingPanel-REXpPXXF.js
assets/ServerConfigPanel-CkZ050bN.js
assets/ServerConfigPanel-DMbHcgPk.js 8.04 kB 2.08 kB 1.84 kB
assets/UserPanel-C8zzJKSe.js 7.76 kB 1.98 kB 1.72 kB
assets/UserPanel-x1sYLhYB.js

Category Total: 74.8 kB

Services

Business logic and services

File Size Gzip Brotli
assets/keybindingService-3V_cl3Da.js 7.21 kB 1.75 kB 1.5 kB
assets/keybindingService-B65MRQxb.js
assets/serverConfigStore-06uSCM8A.js
assets/serverConfigStore-DK_B3JiC.js 2.79 kB 891 B 782 B

Category Total: 10 kB

Utilities

Helper functions and utilities

File Size Gzip Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 525 B 452 B

Category Total: 1.07 kB

Other

Uncategorized bundles

File Size Gzip Brotli
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js 1.12 kB 577 B 494 B

Category Total: 1.12 kB


Overall Total Size: 12.5 MB
Total Bundle Count: 15

}

return doNotUseOccupied ? -1 : (occupiedSlot ?? -1)
return doNotUseOccupied ? -1 : occupiedSlot ?? -1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated prettier change?

@github-actions
Copy link

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Prettier formatting

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-byrne christian-byrne merged commit bfe083d into main Oct 18, 2025
2 checks passed
@christian-byrne christian-byrne deleted the austin/move-subgraph-badge branch October 18, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node badges not disabling [Feature Request]: Add button on top right of subgraph nodes that allows you to enter them

4 participants