-
Notifications
You must be signed in to change notification settings - Fork 393
Move subgraph badge into node title #6115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 10/18/2025, 05:04:20 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/18/2025, 04:50:53 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportApp Entry PointsMain application bundles
Category Total: 11.7 MB Core ViewsMajor application views and screens
Category Total: 721 kB UI PanelsSettings and configuration panels
Category Total: 74.8 kB ServicesBusiness logic and services
Category Total: 10 kB UtilitiesHelper functions and utilities
Category Total: 1.07 kB OtherUncategorized bundles
Category Total: 1.12 kB Overall Total Size: 12.5 MB |
src/lib/litegraph/src/LGraphNode.ts
Outdated
| } | ||
|
|
||
| return doNotUseOccupied ? -1 : (occupiedSlot ?? -1) | ||
| return doNotUseOccupied ? -1 : occupiedSlot ?? -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated prettier change?
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Design docs show icon as being reversed in litegraph mode. If needed, fixing this is basically just removing a negative sign.
LiteGraph implementation was not as clean as I hoped. I can spend some more time divining some non-magic constants, and mayybe resolve the svg data from css styles if desired.
Resolves #4647
Resolves #6107
┆Issue is synchronized with this Notion page by Unito