Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 18, 2025

Summary

Added configurable base branch selection to version bump workflows, enabling patch releases from core/* branches via GitHub Actions UI.

Changes

  • What: Extended workflow_dispatch inputs with branch parameter for both main frontend and desktop-ui version bump workflows
  • Validation: Added branch existence check that lists available core/* branches on error
  • Workflow modifications:
    • release-version-bump.yaml: Checkout and create PRs targeting user-specified branch
    • version-bump-desktop-ui.yaml: Same behavior for desktop-ui releases

Review Focus

Branch validation logic correctly handles both local (refs/heads/) and remote (refs/remotes/origin/) refs. Default value preserves backward compatibility for release sheriffs unfamiliar with new feature.

Use Case

Previously, patch releases from core/1.29 required manual version bumping. Now maintainers can trigger from Actions UI with dropdown selections.

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 18, 2025
@github-actions
Copy link

github-actions bot commented Oct 18, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 10/18/2025, 08:27:43 AM UTC

📈 Summary

  • Total Tests: 500
  • Passed: 469 ✅
  • Failed: 0
  • Flaky: 1 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 460 / ❌ 0 / ⚠️ 1 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Oct 18, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/18/2025, 08:14:36 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

Bundle Size Report

App Entry Points

Main application bundles

File Size Gzip Brotli
assets/index-Dxw6d55T.js 9.67 MB 1.99 MB 1.43 MB
assets/index-MgVpi94-.js 2.02 MB 381 kB 296 kB
assets/index-PESgPnbc.js 507 B 292 B 249 B

Category Total: 11.7 MB

Core Views

Major application views and screens

File Size Gzip Brotli
assets/GraphView-D8od12x4.js 713 kB 139 kB 108 kB
assets/UserSelectView-BvzxtqjF.js 7.99 kB 2.4 kB 2.1 kB

Category Total: 721 kB

UI Panels

Settings and configuration panels

File Size Gzip Brotli
assets/AboutPanel-BmgJ3RUl.js 10.1 kB 2.58 kB 2.27 kB
assets/CreditsPanel-Onm11UFv.js 21.9 kB 5.21 kB 4.54 kB
assets/ExtensionPanel-DbpMns0L.js 11.9 kB 2.74 kB 2.4 kB
assets/KeybindingPanel-iZYgTzSz.js 15.1 kB 3.68 kB 3.24 kB
assets/ServerConfigPanel-DMbHcgPk.js 8.04 kB 2.08 kB 1.84 kB
assets/UserPanel-C8zzJKSe.js 7.76 kB 1.98 kB 1.72 kB

Category Total: 74.8 kB

Services

Business logic and services

File Size Gzip Brotli
assets/keybindingService-3V_cl3Da.js 7.21 kB 1.75 kB 1.5 kB
assets/serverConfigStore-DK_B3JiC.js 2.79 kB 891 B 782 B

Category Total: 10 kB

Utilities

Helper functions and utilities

File Size Gzip Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 525 B 452 B

Category Total: 1.07 kB

Other

Uncategorized bundles

File Size Gzip Brotli
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js 1.12 kB 577 B 494 B

Category Total: 1.12 kB


Overall Total Size: 12.5 MB
Total Bundle Count: 15

@christian-byrne christian-byrne merged commit c6b528b into main Oct 18, 2025
35 checks passed
@christian-byrne christian-byrne deleted the add-base-branch-to-release-dispatch branch October 18, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CI/CD size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants