Skip to content

Conversation

@snomiao
Copy link
Member

@snomiao snomiao commented Oct 19, 2025

Summary

This PR migrates from @trivago/prettier-plugin-sort-imports to the faster @prettier/plugin-oxc parser combined with @ianvs/prettier-plugin-sort-imports for import organization.

Changes

  • Added: @prettier/plugin-oxc - Official Prettier plugin using the OXC (Rust-based) parser for significantly faster formatting
  • Added: @ianvs/prettier-plugin-sort-imports - Import sorting plugin compatible with oxc
  • Removed: @trivago/prettier-plugin-sort-imports - Replaced by the faster combination above
  • Updated: .prettierrc configuration to:
    • Use both new plugins in the correct order
    • Configure TypeScript version for proper type import handling
    • Adapt import order configuration to use inline blank strings instead of separate options
  • Reformatted: All files using the new plugin configuration

Benefits

  1. Faster formatting - OXC parser is written in Rust and provides significant performance improvements
  2. Better compatibility - @ianvs/prettier-plugin-sort-imports is actively maintained and designed to work with modern Prettier plugins
  3. Same functionality - Maintains the same import ordering and grouping behavior

Test Plan

  • Verified formatting works correctly with pnpm format:check:no-cache
  • Reformatted all files successfully
  • No formatting errors or warnings (except for files in .eslintignore)

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

Replace @trivago/prettier-plugin-sort-imports with @prettier/plugin-oxc
and @ianvs/prettier-plugin-sort-imports for improved performance.

Changes:
- Add @prettier/plugin-oxc (Rust-based fast parser)
- Add @ianvs/prettier-plugin-sort-imports (import sorting compatible with oxc)
- Remove @trivago/prettier-plugin-sort-imports
- Update .prettierrc to use new plugins and compatible import order config
- Reformat all files with new plugin configuration

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 19, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/19/2025, 12:04:49 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Oct 19, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 10/19/2025, 12:21:07 AM UTC

📈 Summary

  • Total Tests: 498
  • Passed: 464 ✅
  • Failed: 0
  • Flaky: 3 ⚠️
  • Skipped: 31 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 455 / ❌ 0 / ⚠️ 3 / ⏭️ 31
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​prettier/​plugin-oxc@​0.0.4100100858780
Added@​ianvs/​prettier-plugin-sort-imports@​4.7.09910010087100

View full report

@github-actions
Copy link

Bundle Size Report

App Entry Points

Main application bundles

File Size Gzip Brotli
assets/index-Bg7kKo_l.js 2.02 MB 380 kB 295 kB
assets/index-CuLZTtAC.js
assets/index-DD4LelvO.js 9.67 MB 1.99 MB 1.43 MB
assets/index-E0kYOj1H.js
assets/index-PESgPnbc.js 507 B 292 B 249 B

Category Total: 11.7 MB

Core Views

Major application views and screens

File Size Gzip Brotli
assets/GraphView-BLQk4ujW.js
assets/GraphView-Di7c753F.js 714 kB 139 kB 108 kB
assets/UserSelectView-CpuduMNi.js 7.99 kB 2.39 kB 2.1 kB
assets/UserSelectView-Kp6GcnoT.js

Category Total: 722 kB

UI Panels

Settings and configuration panels

File Size Gzip Brotli
assets/AboutPanel-Bq9ApgWv.js
assets/AboutPanel-DjdjoVYd.js 10.1 kB 2.58 kB 2.27 kB
assets/CreditsPanel-CVBAywTM.js
assets/CreditsPanel-CWz6aNSw.js 21.9 kB 5.21 kB 4.55 kB
assets/ExtensionPanel-CLmbF5YN.js 11.9 kB 2.75 kB 2.4 kB
assets/ExtensionPanel-DFmOwtDV.js
assets/KeybindingPanel-IQI7hKov.js
assets/KeybindingPanel-LZlGcpvh.js 15.1 kB 3.68 kB 3.24 kB
assets/ServerConfigPanel-D2PD5OIf.js
assets/ServerConfigPanel-DZ2tjMig.js 8.04 kB 2.08 kB 1.84 kB
assets/UserPanel-D0nz-wnp.js
assets/UserPanel-DJNo1RD8.js 7.76 kB 1.98 kB 1.72 kB

Category Total: 74.8 kB

Services

Business logic and services

File Size Gzip Brotli
assets/keybindingService-B3C-CFfo.js 7.21 kB 1.75 kB 1.5 kB
assets/keybindingService-Cnd76Vc_.js
assets/serverConfigStore-a9ILJQUc.js 2.79 kB 888 B 777 B
assets/serverConfigStore-CB-AA3JS.js

Category Total: 10 kB

Utilities

Helper functions and utilities

File Size Gzip Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 525 B 452 B

Category Total: 1.07 kB

Other

Uncategorized bundles

File Size Gzip Brotli
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js 1.12 kB 577 B 494 B

Category Total: 1.12 kB


Overall Total Size: 12.5 MB
Total Bundle Count: 15

@snomiao
Copy link
Member Author

snomiao commented Oct 19, 2025

unlucky

@snomiao snomiao closed this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant