Skip to content

Style: Remove currently non-functional collapsed slots #6264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2025
Merged

Style: Remove currently non-functional collapsed slots #6264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d92f08e
fix: Remove unqualified group class on node
DrJKL Oct 24, 2025
332f35f
style: Remove hover behavior from the collapsed "slots"
DrJKL Oct 24, 2025
e59fa76
style: remove pseudo-slots for now, can re-add with the behavior later.
DrJKL Oct 25, 2025
bc9281c
[automated] Update test expectations
invalid-email-address Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...odes/groups/groups.spec.ts-snapshots/vue-groups-create-group-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...inks/linkInteraction.spec.ts-snapshots/vue-node-snap-to-node-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...inks/linkInteraction.spec.ts-snapshots/vue-node-snap-to-slot-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...interactions/node/move.spec.ts-snapshots/vue-node-moved-node-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 1 addition & 6 deletions src/renderer/extensions/vueNodes/components/LGraphNode.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
:class="
cn(
'bg-node-component-surface',
'lg-node absolute rounded-2xl touch-none flex flex-col group',
'lg-node absolute rounded-2xl touch-none flex flex-col',
'border-1 border-solid border-node-component-border',
// hover (only when node should handle events)
shouldHandleNodePointerEvents &&
Expand Down Expand Up @@ -44,10 +44,6 @@
@contextmenu="handleContextMenu"
>
<div class="flex items-center">
<template v-if="isCollapsed">
<SlotConnectionDot multi class="absolute left-0 -translate-x-1/2" />
<SlotConnectionDot multi class="absolute right-0 translate-x-1/2" />
</template>
<NodeHeader
:node-data="nodeData"
:collapsed="isCollapsed"
Expand Down Expand Up @@ -160,7 +156,6 @@ import NodeContent from './NodeContent.vue'
import NodeHeader from './NodeHeader.vue'
import NodeSlots from './NodeSlots.vue'
import NodeWidgets from './NodeWidgets.vue'
import SlotConnectionDot from './SlotConnectionDot.vue'

// Extended props for main node component
interface LGraphNodeProps {
Expand Down
4 changes: 2 additions & 2 deletions src/renderer/extensions/vueNodes/components/SlotConnectionDot.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ defineExpose({
cn(
'bg-slate-300 rounded-full',
'transition-all duration-150',
'cursor-crosshair',
'border border-solid border-node-component-slot-dot-outline',
'group-hover/slot:[--node-component-slot-dot-outline-opacity-mult:5] group-hover/slot:scale-125',
!multi &&
'cursor-crosshair group-hover/slot:[--node-component-slot-dot-outline-opacity-mult:5] group-hover/slot:scale-125',
multi ? 'w-3 h-6' : 'size-3'
)
"
Expand Down