Conversation
- REFACTOR: changed survey route intercept from my to my2 - FEAT: survey_template now overrides default survey with 2025 theme components - CHORE: added theme_compassion_2025 to my_compassion_segmentation dependencies - REFACTOR: overriding default odoo survey styling - FEAT: added optional type and value to themed button
- REFACTOR: hide branding, override continue button, progress bar - FEAT: added css rules for odoo progress bar override - STYLE: commented custom survey scss selectors - FIX: removed default 'button' type from themed button
Summary of ChangesHello @Danielgergely, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience of Odoo survey pages by applying the "2025 theme" styling. It involves integrating the new theme module, refactoring existing routes to support themed pages, and extensively overriding default Odoo survey templates and CSS to align with the desired visual design. The changes ensure a consistent look and feel across the application, dynamically hiding and replacing standard Odoo components with custom-themed equivalents while preserving survey functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant styling overrides for Odoo's survey module, integrating it with the 2025 theme. Key changes include hiding Odoo branding, restyling survey elements like titles, buttons, and progress bars, and adding new routes for /my2 access. The changes effectively transform the default survey appearance to align with the new theme. However, there are a few areas where the implementation could be made more robust and maintainable, particularly concerning the parsing of HTML content and the use of CSS specificity.
theme_compassion_2025/static/src/scss/components/_survey_form.scss
Outdated
Show resolved
Hide resolved
- FEAT: new override template for dynamic inserting of the useful links of a partner - FEAT: added new footer_links template to manifest - FEAT: added footer hook to provide the ability to insert dynamic content into the footer
- FIX: this fix should make sure that buttons in close proximity don't touch each other. a lot cleaner and better solution.
- REFACTOR: the footer_links.xml it now located in the templates folder
|
Related PR: CompassionCH/compassion-modules#2081 (partner_segmentation module changes) |
- This should enable us to merge until the partner links and segmentation topics are decided
NoeBerdoz
left a comment
There was a problem hiding this comment.
Thank you very much for your work! Here is a few things to take in account before we can merge your work 👍
theme_compassion_2025/static/src/scss/components/_survey_form.scss
Outdated
Show resolved
Hide resolved
theme_compassion_2025/templates/components/buttons/ThemedButton.xml
Outdated
Show resolved
Hide resolved
|
Also, while taking in account my review, please fix the git conflict for a smooth merge afterward 😎 |
# Conflicts: # theme_compassion_2025/templates/components/buttons/ThemedButton.xml
This PR includes changes which enable the 2025 theme to override the style of the default survey page from odoo. It dynamically hides & replaces components while keeping the content untouched.
Here is how the survey now looks like:

Start page
First page:

Second page:

Third page:

Thank you page:

Progress bar:

The footer with the dynamic links:

on mobile:
