Skip to content

[T2921] STYLE: my_compassion <alt> tags#299

Open
Danielgergely wants to merge 2 commits into14.0from
T2921-alt-tags
Open

[T2921] STYLE: my_compassion <alt> tags#299
Danielgergely wants to merge 2 commits into14.0from
T2921-alt-tags

Conversation

@Danielgergely
Copy link
Member

  • STYLE: Added missing tags to images

- STYLE: Added missing <alt> tags to images
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the accessibility and semantic structure of the application's web pages by systematically adding alt attributes to image elements. This change ensures that visual content is properly described, which is crucial for users relying on assistive technologies and contributes to better SEO practices. The modifications are purely stylistic and do not alter any functional aspects of the application.

Highlights

  • Accessibility Improvement: Added missing alt attributes to various image tags across several templates to improve web accessibility and provide meaningful descriptions for screen readers and in cases where images fail to load.
  • Template Updates: Updated my_account_my_children.xml, my2_dashboard.xml, my2_gift_package.xml, my2_login_template.xml, and my2_new_letter.xml to include alt tags for child pictures, dashboard banners, payment method logos, login header images, and letter templates/attachments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • my_compassion/templates/my_account_my_children.xml
    • Added a dynamic alt attribute for child picture images, defaulting to 'Child Picture'.
  • my_compassion/templates/pages/my2_dashboard.xml
    • Included an alt attribute with the value 'Banner' for the dashboard banner image.
  • my_compassion/templates/pages/my2_gift_package.xml
    • Added specific alt attributes ('Mastercard', 'Visa', 'Twint', 'Post Finance') to payment method logo images.
  • my_compassion/templates/pages/my2_login_template.xml
    • Set the alt attribute to 'Header picture' for the login page's header image.
  • my_compassion/templates/pages/my2_new_letter.xml
    • Added a dynamic alt attribute for selected letter template images, using the template's name.
    • Included a dynamic alt attribute for attachment images, defaulting to 'attachment'.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds missing alt tags to images across several templates, which is a great step for improving accessibility. My review focuses on making these alt tags more descriptive and aligned with accessibility best practices. I've suggested using more specific text for child pictures, using empty alt tags for purely decorative images, and providing better fallback text for user-uploaded attachments.

Note: Security Review has been skipped due to the limited scope of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant