[T3037] FIX: event banner color and target now correct

[Danielgergely]

• STYLE: simplified render banner condition and added docstrings
• FEAT: added target black to event.banner model
• FEAT: added target blank selector to banner_view.xml
• FIX: the text color is now correctly applied and the target is also specified

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the event banner functionality by introducing a new configuration option to control whether banner links open in a new tab. It also addresses a styling issue to ensure banner text colors are correctly applied and improves the readability and maintainability of the banner retrieval logic through docstrings and code simplification.

Highlights

• Event Banner Logic Refinement: The get_active_banner method in the controller has been refactored for clarity and efficiency, including the addition of docstrings and a more concise banner rendering loop.
• New 'Open in New Tab' Feature: A new boolean field target_blank has been added to the EventBanner model, allowing administrators to configure whether banner links open in a new tab or the same window.
• Dynamic Text Color Application: The event banner template now correctly applies the text_color class to the banner's title and description, ensuring proper styling.
• Banner Link Target Control: The banner button's target attribute is now dynamically set based on the new target_blank field, providing functional control over link behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• my_compassion/controllers/my2_event_banner.py
  • Added docstrings to _normalize_current_page_route and get_active_banner functions for improved code documentation.
  • Introduced a return type hint for the get_active_banner method.
  • Enhanced readability of the banner filtering domain with inline comments.
  • Refactored the banner rendering logic into a more concise list comprehension.
• my_compassion/models/my2_event_banner.py
  • Added a new target_blank boolean field to the EventBanner model, defaulting to True.
  • Updated a comment in _get_default_color_by_name from German to English.
• my_compassion/views/my2_event_banner_views.xml
  • Included the new target_blank field in the event banner form view for UI configuration.
• theme_compassion_2025/templates/components/EventBanner.xml
  • Modified the banner title and description p tags to dynamically apply the banner.text_color.class_name.
  • Added a dynamic target attribute to the banner button, setting it to _blank or _self based on the banner.target_blank field.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a feature to open event banner links in a new tab, fixes a text color issue, and improves code style by adding docstrings and refactoring a loop. My review includes a critical fix for a typo in an XML template that would break styling, a suggestion to improve code documentation and correct a comment, and a minor refactoring for more idiomatic Odoo code.