Skip to content

[T3038] FIX: changed tab names to MyCompassion#301

Open
Danielgergely wants to merge 9 commits into14.0from
T3038-tab-name
Open

[T3038] FIX: changed tab names to MyCompassion#301
Danielgergely wants to merge 9 commits into14.0from
T3038-tab-name

Conversation

@Danielgergely
Copy link
Member

  • FEAT: created an override template for titles in all MyCompassion pages
  • FEAT: added template override to manifest
image

- FEAT: created an override template for titles in all MyCompassion pages
- FEAT: added template override to manifest
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the website title across all MyCompassion pages by implementing a global title override. This change ensures consistent branding and user experience by displaying 'MyCompassion' in the browser tab for every page within the application.

Highlights

  • Website Title Override: A new template has been introduced to override the default website title, ensuring all MyCompassion pages consistently display 'MyCompassion' in the browser tab.
  • Manifest Update: The new title override template has been added to the module's manifest file, making it an integral part of the application's loaded assets.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • my_compassion/manifest.py
    • Added 'templates/website_title_override.xml' to the list of data files.
  • my_compassion/templates/website_title_override.xml
    • Created a new XML template file.
    • Defined an Odoo template that inherits from 'website.layout'.
    • Used an XPath expression to replace the existing title element with a new one containing 'MyCompassion'.
Activity
  • No specific review comments or activity have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to change the browser tab title to 'MyCompassion' by overriding an Odoo template. No security vulnerabilities were identified. However, the current implementation incorrectly applies a static title to the entire website, negatively impacting SEO and user experience by removing dynamic page titles. Please address this fundamental issue by adopting a more targeted approach, as detailed in the critical comment. Additionally, consider improving code maintainability by following best practices for naming template IDs, as suggested in the medium-severity comment.

- REFACTOR: using record with website filter to avoid global override and replace command
pre-commit complained again as usual
Copy link
Contributor

@NoeBerdoz NoeBerdoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposition!

But actually, it's not the wanted approach, I'm sorry I should have been clearer on the task description, that's on me.

The issue is that, our pages names are inconsistent, sometimes MC2 shows "My Compassion 2 <page_name> " sometimes "My account", sometimes, something else, etc.

We need to review the individual templates for the portal pages. Odoo naturally constructs the tab title using the template's name attribute followed by the Website Name. We need to make them all consistent. The goal is for the platform to show tab names as so (which is the default Odoo way) <page_name> | My Compassion

Odoo's set the tab name as so: template name attribute + pipe "|" + website name.

Currently our website name is "MyCompassion", this can be change on production, in Website -> Configuration.

Danielgergely and others added 6 commits March 6, 2026 16:07
- REFACTOR: applied <t t-set="additional_title">Page Title</t> to all mycompassion pages
- REFACTOR: additional_titles's are now passed on from the controllers (and are translated now)
- REFACTOR: added reset password intercept controller
- FEAT: added translation paths and new translations for new titles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants