T3035 muskathlon new registration

[Danielgergely]

FEAT: Created a new new registration view with all relevant registration details

• REFACTOR: adapted the notify_muskathlon_registration method to use the new template
• FIX: whitelisted comments
• FEAT: added new view to manifest

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Muskathlon registration process by introducing a dedicated and detailed notification view. The primary goal is to provide a comprehensive summary of new participant registrations, including all relevant personal, contact, and sport-related information, directly within the notification emails. This change streamlines the communication of registration details by integrating a new QWeb template and updating the backend logic to leverage this improved view, alongside making a new 'comments' field available for user input.

Highlights

• New Registration Notification View: Implemented a new QWeb template to generate detailed notifications for Muskathlon registrations, displaying comprehensive participant information.
• Refactored Notification Method: The notify_muskathlon_registration method was updated to utilize the newly created muskathlon_registration_notification_view template for sending registration alerts.
• Comments Field Added and Whitelisted: A new comments text field was added to the MuskathlonRegistration model and subsequently whitelisted for use within the form builder.
• Manifest Update: The module's manifest file was updated to include the new registration_mail_template.xml.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• muskathlon/manifest.py
  • Added 'data/registration_mail_template.xml' to the list of data files loaded by the module.
• muskathlon/data/registration_mail_template.xml
  • Created a new QWeb template named 'muskathlon_registration_notification_view' to format detailed registration notifications, including participant name, email, phone, birth details, passport info, emergency contacts, address, T-shirt size, sport discipline, sport level, and comments.
• muskathlon/models/event_registration.py
  • Added a new comments field of type Text to the MuskathlonRegistration model.
  • Corrected a grammatical error in the docstring for the _compute_is_in_two_months method.
  • Modified the notify_muskathlon_registration method to use message_post_with_view with the new 'muskathlon.muskathlon_registration_notification_view' template, replacing the previous generic message_post call.
• muskathlon/templates/muskathlon_registration_form.xml
  • Whitelisted the 'comments' field for the 'event.registration' model, allowing it to be used in the form builder.

Activity

• No human activity recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new registration notification view for Muskathlon events, refactors the notification sending logic to use it, and adds a 'comments' field to the registration form. A critical security vulnerability has been identified: the new registration notification template includes sensitive Personally Identifiable Information (PII), such as passport numbers and dates of birth, which is sent to all event followers. This poses a significant risk of PII leakage and unauthorized data access, especially via cleartext email. It is strongly recommended to remove sensitive details from the email template and instead provide a secure link to the Odoo record for authorized users to view these details. Additionally, a performance issue was noted in the new email template where fields_get is used inefficiently; direct access to field properties is suggested for improvement.