direct identity credentials, integration with web3id #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanbrondum
changed the title
allanbrondum
commented
Oct 15, 2025
Comment on lines
+730
to
+738
| struct GivenContextInfo { | ||
| // Randomly generated nonce. It is important that the nonce is freshly generated by the backend | ||
| // for each request so that the presentation request anchor on-chain truely looks random. | ||
| nonce: Sha256Challenge, | ||
| // Human readable string giving more context to the request. | ||
| context_string: String, | ||
| // The topic of the wallet connection as defined by `walletConnect`. | ||
| // The wallet or ID app use this value to check that the topic matches the current active connection. | ||
| // TODO: Should we decide on a fix-sized length type `e.g. a type that will represent the walletConntect topic`. |
There was a problem hiding this comment.
I think the properties should be dynamically represented and not as hardcoded fields? The web3id module may not even need to know the different properties.
allanbrondum
commented
Oct 15, 2025
| requested: RequestedContextInfo, | ||
| } | ||
|
|
||
| // This data is suppose to be provided by the dapp backend (e.g. merchant backend). |
There was a problem hiding this comment.
Docs on an item needs three slashes: ///
There was a problem hiding this comment.
Else it is just a comment
allanbrondum
commented
Oct 15, 2025
|
|
||
| /// A trait that represents a challenge in a proof response request protocol. | ||
| /// Types implementing this trait define how they can be incorporated into a cryptographic transcript (random oracle). | ||
| pub trait IsChallenge: |
There was a problem hiding this comment.
If we need a polymorphic behaviour for different types of challenges, I think we should settle on one approach. Either an enum, or a trait that you implement. Having both seems redundant?
There was a problem hiding this comment.
(enum is for variation of a fixed set of behaviours, while the trait is open for extension, not sure which one is best here)
Base automatically changed from
ar/cor-1971-identity-credential-attributes-prover-and-verifier-simplify
to
ar/cor-1939-verifiable-presentations-from-id-credentials-feature
October 15, 2025 10:43
allanbrondum
changed the base branch from
ar/cor-1939-verifiable-presentations-from-id-credentials-feature
to
ar/cor-1972-identity-credential-attributes-prover-and-verifier-optimize-id-cred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Try to integrate identity attributes directly from identity credentials directly into the
web3idmoduleChanges
_Describe the changes that were needed.
Checklist
hard-to-understand areas.