Skip to content

Conversation

@Radiokot
Copy link
Member

  • Fixed always empty tokens in AccountInfo

@Radiokot Radiokot merged commit c8747a9 into main Sep 29, 2025
7 checks passed
@Radiokot Radiokot deleted the release/11.0.2 branch September 29, 2025 11:56
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.0</version>
<configuration>
<useIncrementalCompilation>false</useIncrementalCompilation>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it costly to rebuild this project? I have just never seen this property in use before, i was just wondering if it has any repercussions if there is a dependency that it has not picked up that has changed?

I feel like removing this configuration option completely is better because you just rebuild from fresh always

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this flag earlier to speed up the build, as without it Maven re-generates all the protobuffs and re-compiles everything every time, which takes more than a minute on my computer.

I added the same entry to the android-sdk module in this branch because the IDE started complaining on module language level, which is aparently set to the correct value when the maven-compiler-plugin is added.

On CI it is built from scratch anyway.

Copy link

@squirer squirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added one comment - i feel like we should just rebuild the project from its source each time rather than using this property to determine if something has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants