Skip to content

Conversation

@Ivan-Mahda
Copy link
Contributor

Purpose

Previously, support for the react-native platform was limited.
This is because wasm was not supported in react-native.
This update adds conversion of the necessary modules to JS to support the full functionality of this library in combination with react-native.

Changes

Additional step of converting wasm to js, for use with react-native
Updated webpack config and build scripts

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Additional step of converting wasm to js, for use with react-native
Updated webpack config and build scripts
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, great work getting this to work! I assume you've tested this with a local project?

Other than that, please update the example at examples/reactnative with something from @concordium/web-sdk/wasm to ensure that it builds successfully in CI. It doesn't matter which function, just an arbitrary one that utilizes @concordium/rust-bindings/wallet.

It would be nice to also have it actually working when you run the application locally, but if that is too much to fit in, it will also suffice to add an issue to do this.

Lastly, I think we should plan a minor version release to get this out ASAP.

@soerenbf
Copy link
Collaborator

soerenbf commented Apr 9, 2025

Also, please ensure that the CI checks pass before merging.

Update CHANGELOG.md and README.md
Updated example for react-native,
ConcordiumHdWallet and wasm usage
Updated example for react-native,
ConcordiumHdWallet and wasm usage
@Ivan-Mahda Ivan-Mahda requested a review from soerenbf April 9, 2025 09:49
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating the example! 🥇

@Ivan-Mahda Ivan-Mahda merged commit eb3fed3 into main Apr 9, 2025
10 checks passed
@Ivan-Mahda Ivan-Mahda deleted the wallet-wasm-to-js-react-native branch April 9, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants