-
Notifications
You must be signed in to change notification settings - Fork 18
Rust bindings wasm2js update for /wallet package #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Additional step of converting wasm to js, for use with react-native Updated webpack config and build scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, great work getting this to work! I assume you've tested this with a local project?
Other than that, please update the example at examples/reactnative with something from @concordium/web-sdk/wasm to ensure that it builds successfully in CI. It doesn't matter which function, just an arbitrary one that utilizes @concordium/rust-bindings/wallet.
It would be nice to also have it actually working when you run the application locally, but if that is too much to fit in, it will also suffice to add an issue to do this.
Lastly, I think we should plan a minor version release to get this out ASAP.
|
Also, please ensure that the CI checks pass before merging. |
Update CHANGELOG.md and README.md
Updated example for react-native, ConcordiumHdWallet and wasm usage
Updated example for react-native, ConcordiumHdWallet and wasm usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for updating the example! 🥇
Purpose
Previously, support for the
react-nativeplatform was limited.This is because
wasmwas not supported inreact-native.This update adds conversion of the necessary modules to
JSto support the full functionality of this library in combination withreact-native.Changes
Additional step of converting wasm to js, for use with react-native
Updated webpack config and build scripts
Checklist
hard-to-understand areas.