-
Notifications
You must be signed in to change notification settings - Fork 18
Feature/forwards compatibility #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward comp/block item summary
Forward comp/chain updates
Forward comp/special events
Forward comp/events
Jira-Id: COR-1841
Jira-Id: COR-1841
Restructure token module types + add reject reason
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
…eason Wrap Upward around RejectReason
Jira-Id: COR-1836
* Add unknown variants to `AccountInfo` * Add unknown variants to uses of `OpenStatusText` for validator pools.
…837-Reward-Status
…Status Wrap Upward around RewardStatus
* Forward compat for parsing encoded token module events * Move cbor decode functionality into its own file * Add parser function for token module reject reasons * Parse token ops * Align tests to introduction of unknown variants + `TokenModuleRejectReason` * Add option to `Cbor.decode` into type `TokenOperation[]` * Update changelog * Add missing jsdoc * Fix examples * Fix tests * Apply PR suggestions * ..
* Wrap `ContractTraceEvent` uses in `Upward` * Remove `ContractVersion` in favor of good ol' `number` * Align helper block item summary functions with rust SDK * Add handle PLT events for block item summary helpers
* `Upward` for `VerifyKey` * Add type for unwrapping `Upward` recursively for types that are used in both read/write scenarios * JSDoc improvements * Align representation of `UpdatePublicKey` in grpc/sdk
squirer
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref COR-1718
Purpose
Make
@concordium/web-sdk(and dependents exposing any of these types) forward compatible by introducing unknown variants in the form ofUpward<T>(among other more specialized unknown variant types) for selected types that can be expected to change in the future.Changes
AccountInfo#498Checklist
hard-to-understand areas.