Update the Rust SDK #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirer
approved these changes
Oct 17, 2025
DOBEN
reviewed
Oct 17, 2025
src/api/block.rs
Outdated
|
|
||
| while let Some(e) = special_events.next().await.transpose()? { | ||
| let Upward::Known(e) = e else { | ||
| warn!("Encountered unknown special transaction outcome; skipping."); |
There was a problem hiding this comment.
I would include info on what to do to remove the warning in all log::warn through out the PR.
Suggested change
| warn!("Encountered unknown special transaction outcome; skipping."); | |
| warn!("Encountered unknown special transaction outcome; skipping. Update the `concordium-rust-sdk` version to remove the warning."); |
There was a problem hiding this comment.
This is not really a solution for a user. In the first place, they might be using a binary distribution. In the second, updating the SDK will also require implementing cases for the new outcomes.
There was a problem hiding this comment.
I have made the log messages say that the node/protocol version may be unsupported by the version of concordium-rosetta.
DOBEN
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Depends on Concordium/concordium-transaction-logger#58
Update the Rust SDK and fix issues.
Changes
Unknowncases.token_updatein/network/options.Checklist
hard-to-understand areas.