Skip to content

Fix constructor name for GeminiCliConfigurator#833

Merged
Scriptwonder merged 1 commit intobetafrom
Scriptwonder-patch-1
Feb 26, 2026
Merged

Fix constructor name for GeminiCliConfigurator#833
Scriptwonder merged 1 commit intobetafrom
Scriptwonder-patch-1

Conversation

@Scriptwonder
Copy link
Collaborator

@Scriptwonder Scriptwonder commented Feb 26, 2026

Quick fix on the constructor name

Summary by Sourcery

Bug Fixes:

  • Fix the constructor name in GeminiCliConfigurator so it matches the class and instantiates correctly.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a naming inconsistency in the Gemini CLI configurator component.

Copilot AI review requested due to automatic review settings February 26, 2026 06:20
@Scriptwonder Scriptwonder merged commit 2b6abf5 into beta Feb 26, 2026
1 of 2 checks passed
@Scriptwonder Scriptwonder deleted the Scriptwonder-patch-1 branch February 26, 2026 06:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d303324 and ed725fa.

📒 Files selected for processing (1)
  • MCPForUnity/Editor/Clients/Configurators/GeminiCliConfigurator.cs

📝 Walkthrough

Walkthrough

Constructor renamed from GeminiConfigurator to GeminiCliConfigurator in the GeminiCliConfigurator class to align the constructor name with the class name, maintaining all initialization logic and base constructor call parameters.

Changes

Cohort / File(s) Summary
Constructor Naming Fix
MCPForUnity/Editor/Clients/Configurators/GeminiCliConfigurator.cs
Constructor signature updated to match class name: GeminiConfigurator()GeminiCliConfigurator(). Base initialization and parameters remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A constructor once bore the wrong name,
But clarity came, now they're the same!
GeminiCliConfigurator stands true and bright,
Constructor aligned—everything's right! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Scriptwonder-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug where the constructor name did not match the class name in the GeminiCliConfigurator class. In C#, constructors must have the exact same name as their containing class, making this a compilation error that needed to be fixed.

Changes:

  • Corrected constructor name from GeminiConfigurator() to GeminiCliConfigurator() to match the class name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 26, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Renames the constructor in GeminiCliConfigurator to match the class name, fixing a naming inconsistency that could prevent proper construction/compilation.

Class diagram for GeminiCliConfigurator constructor fix

classDiagram
    class JsonFileMcpConfigurator

    class McpClient {
        string name
        string windowsConfigPath
    }

    class GeminiCliConfigurator {
        +GeminiCliConfigurator()
    }

    GeminiCliConfigurator --|> JsonFileMcpConfigurator
    GeminiCliConfigurator o--> McpClient
Loading

File-Level Changes

Change Details Files
Aligns the constructor name with the GeminiCliConfigurator class to fix a naming/compilation issue.
  • Renamed the constructor from GeminiConfigurator to GeminiCliConfigurator.
  • Kept the base JsonFileMcpConfigurator initialization with McpClient configuration unchanged.
MCPForUnity/Editor/Clients/Configurators/GeminiCliConfigurator.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants