Open
Conversation
quajak
requested changes
Jan 1, 2024
Member
quajak
left a comment
quajak
left a comment
There was a problem hiding this comment.
This solution works but I am not sure that we will always have Cosmos.Core be assembly 1 to be loaded, which makes this a bit brittle.
I would prefer if we fix the issue by not emitting the assembly number for AsmLabels/AsmMarkers
Member
Author
|
Kind of agree but why assembly numbers was added? |
Member
|
Because they were added everywhere to ensure that we would not get collisions if two assemblies are called the same and have the same class. The implementation has a few unfortunate side effects since certain labels were hard-coded, like this case. |
|
Why not replace it for something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.