Conversation
config/deploy.rb
Outdated
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
hey @allenwq, can you spare another pair of eyes to look through this PR? The idea is that we want to use codeship to deploy via capistrano so that we can kill jenkins and free up some memory and space on our server. |
|
Please ignore the hound violations. I will fix that in a separate PR. Thanks! |
There was a problem hiding this comment.
@jsyeo If this file is removed, what's the new way of restarting the server ?
There was a problem hiding this comment.
Hence capistrano. Use cap production puma:restart from your local machine while in the coursemology dir. There's no need to ssh in to restart it.
There was a problem hiding this comment.
Once this is merged, I will then write upstart scripts to manage nginx, puma and delayed job so that they will be automatically started when the server reboots
There was a problem hiding this comment.
@jsyeo Can we don't update all the gems or do this in another PR ?
I'm afraid this could introduce some unknown bugs since we don't have enough test cases. Like last time our html5 editor was broken after we installed a new version.
|
Also, we should fix travis. |
|
My concern with this PR is that we're mixing the open source components with our own proprietary information. Might not be a problem for v1, but would definitely need to be addressed for v2. I'm +0 on this for v1, a similar PR for v2 would get a -1 from me... |
4 participants
instead of that memory hungry jenkins