Add E2E testing framework #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraible
force-pushed
the
add-e2e-tests
branch
2 times, most recently
from
2fd84c1 to
563ca07
Compare
mraible
force-pushed
the
add-e2e-tests
branch
3 times, most recently
from
8e8be5d to
96de518
Compare
mraible
force-pushed
the
add-e2e-tests
branch
from
96de518 to
37ced6c
Compare
Addresses PR feedback from Javier to avoid mixing import/require syntax
- Update AppCatalogPage waitForInstallation() to wait for both 'installing' and 'installed' toast messages sequentially - Update foundry.spec.ts workflow action verification to handle stale actions from previous installs - Check for 'Configure' heading as indicator of valid current action vs stale action
…k extraction - Rename configureServiceNowIfNeeded() to configureApiIntegrationIfNeeded() - Add comprehensive documentation explaining the method is designed for framework extraction - Note that method is a no-op for apps without API integrations - Mark with @future-framework-extraction tag for easy identification during extraction
This app has no UI/pages, so this method is not needed.
- Create new AppBuilderPage with disableWorkflowProvisioning method - Navigate to App Builder and disable provision_on_install for all workflows - Deploy and release changes so they're available for installation - Update app-install.setup.ts to call disableWorkflowProvisioning - Remove run-e2e-local.sh as it's no longer needed - This prevents E2E test failures due to missing external API credentials Co-Authored-By: Claude <[email protected]>
…ail on validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive E2E testing for the ServiceNow IDP sample app using Playwright.
Test Coverage
Test Results
All 4 tests passing:
Total runtime: ~1.5 minutes
Key Implementation Details
https://example.com) to pass backend validationprovision_on_install: false)