reworking dirichlet bcs to hold onto velocity and acceleration values… #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/funcs as well. Created DIrichletBCFunc type and did some cleanups elsewehre. Also renamed method to update_field_dirichlet_bcs to be more clear than update_field_bcs to clearly state which types of bcs are being updated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 88.53% 87.63% -0.90%
==========================================
Files 43 43
Lines 1631 1650 +19
==========================================
+ Hits 1444 1446 +2
- Misses 187 204 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/funcs as well. Created DIrichletBCFunc type and did some cleanups elsewehre. Also renamed method to update_field_dirichlet_bcs to be more clear than update_field_bcs to clearly state which types of bcs are being updated.