Adding a skeleton for an AMDGPU extension. #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 34.26% 34.17% -0.10%
==========================================
Files 38 39 +1
Lines 2136 2142 +6
==========================================
Hits 732 732
- Misses 1404 1410 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sounds great! I’ll definitely check it out!
…________________________________
From: Craig Hamel ***@***.***>
Sent: Saturday, March 29, 2025 6:12:48 PM
To: Cthonios/FiniteElementContainers.jl ***@***.***>
Cc: Mota, Alejandro ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] [Cthonios/FiniteElementContainers.jl] Adding a skeleton for an AMDGPU extension. (PR #86)
@lxmota<https://github.com/lxmota> I put together what the AMDGPU.jl package extension should look like. It's a mirror of the current CUDA extension I have in place.
I can't really test this right now so whenever you get a chance, let me know if it works. I'm planning on getting an AMD chip in the near future.
________________________________
You can view, comment on, or merge this pull request online at:
#86
Commit Summary
* 635fb31<635fb31> Adding a skeleton for an AMDGPU extension.
File Changes
(2 files<https://github.com/Cthonios/FiniteElementContainers.jl/pull/86/files>)
* M Project.toml<https://github.com/Cthonios/FiniteElementContainers.jl/pull/86/files#diff-72ed386c2a0cd1d23c0968297e70023ed98c22490d146dd89fc91f48369bad4d> (5)
* A ext/FiniteElementContainersAMDGPUExt.jl<https://github.com/Cthonios/FiniteElementContainers.jl/pull/86/files#diff-13031f5f300713924a4fba6ea30d011d17305d87e0796df489ffe5d5c99d1496> (26)
Patch Links:
* https://github.com/Cthonios/FiniteElementContainers.jl/pull/86.patch
* https://github.com/Cthonios/FiniteElementContainers.jl/pull/86.diff
—
Reply to this email directly, view it on GitHub<#86>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABWKJANEU2EGN3UIT3WF7PT2W5AJBAVCNFSM6AAAAAB2B544RKVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2TQNJZGM3TMMA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lxmota I put together what the
AMDGPU.jlpackage extension should look like. It's a mirror of the current CUDA extension I have in place.I can't really test this right now so whenever you get a chance, let me know if it works. I'm planning on getting an AMD chip in the near future.
Just FYI, if you're not too familiar with package extensions... you can load this in the REPL as follows
using FiniteElementContainers, Adapt, AMDGPUand that will load in the
Adaptand theAMDGPUpackage extensions.You can mimic the TestPoissonCUDA.jl example for testing purposes.