Fix testAdvancementInsertRecipePlanks game test always failing#183
Merged
rubensworks merged 7 commits intomaster-1.21-ltsfrom Feb 28, 2026
Merged
Conversation
…ndition Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add game tests for all advancements in mod
Add game tests for all advancements
Feb 28, 2026
… mock connection Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
Add game tests for all advancements
Fix advancement game tests failing with "Payload may not be sent to client"
Feb 28, 2026
Copilot stopped work on behalf of
rubensworks due to an error
February 28, 2026 15:30
… workaround Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
Fix advancement game tests failing with "Payload may not be sent to client"
Bump integrateddynamics to 1.32.0-1630 and remove mock player workaround
Feb 28, 2026
Copilot stopped work on behalf of
rubensworks due to an error
February 28, 2026 15:39
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
Bump integrateddynamics to 1.32.0-1630 and remove mock player workaround
Bump integrateddynamics to 1.32.0-1630 and fix advancement game tests
Feb 28, 2026
Copilot stopped work on behalf of
rubensworks due to an error
February 28, 2026 16:19
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
Bump integrateddynamics to 1.32.0-1630 and fix advancement game tests
Fix testAdvancementInsertRecipePlanks game test always failing
Feb 28, 2026
Copilot stopped work on behalf of
rubensworks due to an error
February 28, 2026 17:02
rubensworks
requested changes
Feb 28, 2026
| "part_type": "integratedcrafting:interface_crafting", | ||
| "variable": { | ||
| "type": "value_type", | ||
| "value": { |
Member
There was a problem hiding this comment.
I don't want this change, as this will match all possible recipes.
I suspect this recipe JSON is fine, but the game test corresponding with it to be incorrect.
Can you have another look?
Make sure you run the game tests yourself locally for debugging.
Contributor
Author
There was a problem hiding this comment.
Reverted the JSON change and fixed the test instead (commit 9158f9d). The test now deserializes the recipe value from the exact same SNBT string that the advancement JSON specifies, so ValueHelpers.areValuesEqual() finds equal values when the ValuePredicate runs. All 31 game tests pass.
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testAdvancementInsertRecipePlanksgame test always failed because the variable created in the test did not match the specific oak planks recipe value that the advancement'sValuePredicateexpects.Changes
GameTestsAdvancements.java: Fixed the test to deserialize the recipe value from the exact same SNBT string specified in the advancement JSON, soValueHelpers.areValuesEqual()finds equal values whenValuePredicate.test()runs:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.