Skip to content

Conversation

@chkim-usgs
Copy link
Contributor

@chkim-usgs chkim-usgs commented Sep 22, 2025

Description

Accommodates new changes in upcoming cspice release.

Do not merge until new cspice is released and pipeline is tested against the new release.

Related Issue

Addresses #5879

How Has This Been Validated?

New cspice with cmake changes was built locally and installed into my local ISIS environment. Was able to build ISIS with this installation and run spiceinit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@chkim-usgs chkim-usgs marked this pull request as ready for review September 23, 2025 12:46
@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

3 similar comments
@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

- bzip2
- cmake >=3.27,<3.28
- cspice =67
- cspice =67=*_11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev anaconda builds are failing too. Need to update the meta.yml as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, there's another issue going on. Basically the same issues for updating to gdal 3.11. There is seemingly a random segfault happening when collecting gtests. I have also run into segfaults when running ISIS apps with the updates in the env file.

I've basically hit a brick wall and can't figure out what the issue is

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured there are more issues going on and that this PR isn't ready yet. I just wanted to throw a comment in here so it's not missed before it's ready for review/merging.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

5 similar comments
@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

- bzip2
- cmake >=3.27,<3.28
- cspice =67
- cspice =67=*_11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the changes in the main environment.yml also need to be applied to the ARM environment yamls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, although some changes may be reverted so once the main environment.yml is finalized then I'll update the variants.

@github-actions
Copy link

Caution

Environment/meta file update notice

You modified one of the environment/meta files but the following files were not updated:

  • recipe/meta.yaml

Please update them as well.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5886".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants