-
Couldn't load subscription status.
- Fork 176
Using updated cspice #5886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Using updated cspice #5886
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
3 similar comments
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
| - bzip2 | ||
| - cmake >=3.27,<3.28 | ||
| - cspice =67 | ||
| - cspice =67=*_11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dev anaconda builds are failing too. Need to update the meta.yml as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, there's another issue going on. Basically the same issues for updating to gdal 3.11. There is seemingly a random segfault happening when collecting gtests. I have also run into segfaults when running ISIS apps with the updates in the env file.
I've basically hit a brick wall and can't figure out what the issue is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured there are more issues going on and that this PR isn't ready yet. I just wanted to throw a comment in here so it's not missed before it's ready for review/merging.
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
5 similar comments
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
| - bzip2 | ||
| - cmake >=3.27,<3.28 | ||
| - cspice =67 | ||
| - cspice =67=*_11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the changes in the main environment.yml also need to be applied to the ARM environment yamls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, although some changes may be reverted so once the main environment.yml is finalized then I'll update the variants.
4fe51ea to
925959e
Compare
|
Caution Environment/meta file update noticeYou modified one of the environment/meta files but the following files were not updated:
Please update them as well. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5886". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
Description
Accommodates new changes in upcoming cspice release.
Do not merge until new cspice is released and pipeline is tested against the new release.
Related Issue
Addresses #5879
How Has This Been Validated?
New cspice with cmake changes was built locally and installed into my local ISIS environment. Was able to build ISIS with this installation and run spiceinit tests.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: