-
Notifications
You must be signed in to change notification settings - Fork 130
[CONTINT-4924] Support for wildcards in Kind field in KSM RBAC #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[CONTINT-4924] Support for wildcards in Kind field in KSM RBAC #2350
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
=======================================
Coverage 36.56% 36.56%
=======================================
Files 281 281
Lines 23911 23914 +3
=======================================
+ Hits 8742 8745 +3
Misses 14485 14485
Partials 684 684
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
tbavelier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in PR description, this requires using 7.74+, so QA can be done with override.clusterChecksRunner.image.name: docker.io/datadog/agent-dev:nightly-main-py3 if using runners, or docker.io/datadog/cluster-agent-dev:master if not using runners.
Also for QA, this indeed requires the readallresources option from the Helm chart template. Or patching directly the clusterrole datadog-operator-manager-role if using make deploy
@triviajon we should probably wait to merge this until 7.74 is released, so possibly with operator 1.23, as 1.22 release cycle will start in mid december
What does this PR do?
This PR adds users to use a wildcard "*" in the Kind field under
.spec.features.kubeStateMetricsCore.collectCrMetricsof theDatadogAgentCR. This comes as a follow-up to the bugfix in datadog-agent/pull/43315, and is the Operator equivalent of this helm-charts/datadog PR.Motivation
What inspired you to submit this pull request?
https://datadoghq.atlassian.net/browse/CONTINT-4924
Additional Notes
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Relies on the bug-fix in
datadog-agentthat likely won't be included until 7.74.0 for the KSM check not to fail, but otherwise no.Describe your test plan
Added a unit-test to feature/kubernetesstatecore/rbac_test.go.
Also QA'd manually:
helm install datadog-operator /Users/jon.rosario/dd/helm-charts/charts/datadog-operator -f deploy-ddo.yaml --set clusterRole.allowReadAllResources=true:Note: if using
make deploy, the operator clusterrole needs to be patched manually to add read to all resourcesNote: this requires image override for runners or DCA if not using runners 7.74+ for QA
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel