Skip to content

Conversation

@kikoveiga
Copy link
Contributor

@kikoveiga kikoveiga commented Oct 15, 2025

What does this PR do?

Adds a new feature RUM Debug Widget, which displays RUM data in real time. It lives inside its own module features/dd-sdk-android-rum-debug-widget.

Motivation

It is useful for customers to understand if our SDK is correctly configured inside their apps and if RUM events are being collected.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

satween and others added 30 commits April 7, 2025 16:21
…novation-week-07-04-25

# Conflicts:
#	features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/Rum.kt
#	features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/RumFeature.kt
#	features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumActionScope.kt
#	features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumApplicationScope.kt
#	features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScope.kt
#	features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumSessionScope.kt
#	features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewManagerScope.kt
#	features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScope.kt
#	features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitor.kt
@kikoveiga kikoveiga changed the title Tvaleev/feature/innovation week 07 04 25 RUM-12059: RUM Debug Widget Nov 26, 2025
@kikoveiga kikoveiga marked this pull request as ready for review December 10, 2025 14:29
@kikoveiga kikoveiga requested review from a team as code owners December 10, 2025 14:29
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 306 to +309
.trackLongTasks(250L)
.trackNonFatalAnrs(true)
.setSlowFramesConfiguration(SlowFramesConfiguration.DEFAULT)
.enableRumDebugWidget(this)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge RUM debug widget call uses debug-only dependency

The sample app invokes enableRumDebugWidget(this) in the main source set, but the widget module is declared as debugImplementation in sample/kotlin/build.gradle.kts (line 155). Release variants compile the main sources without the debug dependency on their classpath, so enableRumDebugWidget will be an unresolved symbol and release builds of the sample (or any app following the README guidance) will fail at compile time. Consider moving the call into a debug-only source set or adding the dependency for release when the call is present.

Useful? React with 👍 / 👎.

joepeeples
joepeeples previously approved these changes Dec 10, 2025
Copy link

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a couple of small style edits, thanks!

@kikoveiga kikoveiga force-pushed the tvaleev/feature/innovation-week-07-04-25 branch from 70e70b0 to e3e4714 Compare December 11, 2025 15:01
@kikoveiga kikoveiga marked this pull request as draft December 11, 2025 15:08
@kikoveiga kikoveiga force-pushed the tvaleev/feature/innovation-week-07-04-25 branch from e3e4714 to b792dbf Compare December 11, 2025 15:09
@kikoveiga kikoveiga force-pushed the tvaleev/feature/innovation-week-07-04-25 branch from 0665d51 to 31690dd Compare December 11, 2025 15:22
@kikoveiga kikoveiga marked this pull request as ready for review December 15, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants