-
Notifications
You must be signed in to change notification settings - Fork 75
RUM-12059: RUM Debug Widget #2943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…novation-week-07-04-25 # Conflicts: # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/Rum.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/RumFeature.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumActionScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumApplicationScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumSessionScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewManagerScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitor.kt
… documentation missing
…et-activity-configuration RUM-12062: Refactor the configuration and integration of the RUM Debug Widget
RUM-12066: Add light theme colors to the RUM Debug Widget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .trackLongTasks(250L) | ||
| .trackNonFatalAnrs(true) | ||
| .setSlowFramesConfiguration(SlowFramesConfiguration.DEFAULT) | ||
| .enableRumDebugWidget(this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUM debug widget call uses debug-only dependency
The sample app invokes enableRumDebugWidget(this) in the main source set, but the widget module is declared as debugImplementation in sample/kotlin/build.gradle.kts (line 155). Release variants compile the main sources without the debug dependency on their classpath, so enableRumDebugWidget will be an unresolved symbol and release builds of the sample (or any app following the README guidance) will fail at compile time. Consider moving the call into a debug-only source set or adding the dependency for release when the call is present.
Useful? React with 👍 / 👎.
joepeeples
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a couple of small style edits, thanks!
70e70b0 to
e3e4714
Compare
e3e4714 to
b792dbf
Compare
Co-authored-by: Joe Peeples <[email protected]>
0665d51 to
31690dd
Compare
What does this PR do?
Adds a new feature RUM Debug Widget, which displays RUM data in real time. It lives inside its own module
features/dd-sdk-android-rum-debug-widget.Motivation
It is useful for customers to understand if our SDK is correctly configured inside their apps and if RUM events are being collected.
Review checklist (to be filled by reviewers)