RUM-13468: Add totalRam, processorCount and isLowRamDevice to DeviceInfo
#3024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
2 times, most recently
from
a5339c4 to
899ef0f
Compare
marco-saia-datadog
changed the title
marco-saia-datadog
changed the title
marco-saia-datadog
changed the title
totalRam, processorCount and isLowRamDevice to DeviceInfo
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
2 times, most recently
from
65945bf to
55a5484
Compare
|
🎯 Code Coverage * Fix with Cursor requires Datadog plugin ≥v2.17.0 🔗 Commit SHA: a4e01bd | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3024 +/- ##
===========================================
+ Coverage 71.25% 71.26% +0.01%
===========================================
Files 866 866
Lines 31734 31807 +73
Branches 5360 5360
===========================================
+ Hits 22610 22665 +55
- Misses 7596 7614 +18
Partials 1528 1528
🚀 New features to boost your workflow:
|
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
from
55a5484 to
c356214
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
from
c356214 to
a4e01bd
Compare
0xnm
reviewed
Dec 11, 2025
Comment on lines
+359
to
+363
| "processor_count": { | ||
| "type" : "number", | ||
| "description": "Number of device processors", | ||
| "readOnly": true | ||
| }, |
Member
There was a problem hiding this comment.
Probably the naming is not the best one, because processor is a chip containing multiple cores. We probably want to send the number of physical cores, right?
Comment on lines
+131
to
+133
| override val processorCount: Int by lazy(LazyThreadSafetyMode.PUBLICATION) { | ||
| Runtime.getRuntime().availableProcessors() | ||
| } |
Member
There was a problem hiding this comment.
not sure if we want to send the number of processors (chips) or cores, but this method returns the number of physical cores and not the number of chips.
| } | ||
| } | ||
|
|
||
| override val processorCount: Int by lazy(LazyThreadSafetyMode.PUBLICATION) { |
Member
There was a problem hiding this comment.
unless we have any performance concerns, we can use default mode
Suggested change
| override val processorCount: Int by lazy(LazyThreadSafetyMode.PUBLICATION) { | |
| override val processorCount: Int by lazy { |
| } | ||
|
|
||
| @Suppress("UnsafeThirdPartyFunctionCall") // Called within a try/catch block | ||
| override val totalRam: Int? by lazy(LazyThreadSafetyMode.PUBLICATION) { |
Member
There was a problem hiding this comment.
Suggested change
| override val totalRam: Int? by lazy(LazyThreadSafetyMode.PUBLICATION) { | |
| override val totalRam: Int? by lazy { |
| } | ||
|
|
||
| @Suppress("UnsafeThirdPartyFunctionCall") // Called within a try/catch block | ||
| override val isLowRamDevice: Boolean? by lazy(LazyThreadSafetyMode.PUBLICATION) { |
Member
There was a problem hiding this comment.
Suggested change
| override val isLowRamDevice: Boolean? by lazy(LazyThreadSafetyMode.PUBLICATION) { | |
| override val isLowRamDevice: Boolean? by lazy { |
| Runtime.getRuntime().availableProcessors() | ||
| } | ||
|
|
||
| @Suppress("UnsafeThirdPartyFunctionCall") // Called within a try/catch block |
Member
There was a problem hiding this comment.
minor: it is better to move this annotation right to the call site rather than to keep it for the whole method. I guess here it will be getMemoryInfo and ActivityManager.MemoryInfo() constructor can be declared as safe in YAML config.
Comment on lines
+30
to
+32
| val processorCount: Int = forge.anInt() | ||
| val totalRam: Int = forge.anInt() | ||
| val isLowRamDevice: Boolean = forge.aBool() |
Member
There was a problem hiding this comment.
Suggested change
| val processorCount: Int = forge.anInt() | |
| val totalRam: Int = forge.anInt() | |
| val isLowRamDevice: Boolean = forge.aBool() | |
| val processorCount = forge.anInt() | |
| val totalRam = forge.aNullable { anInt() } | |
| val isLowRamDevice = forge.aNullable { aBool() } |
Comment on lines
+29
to
+30
| totalRam = forge.anInt(), | ||
| isLowRamDevice = forge.aBool() |
Member
There was a problem hiding this comment.
Suggested change
| totalRam = forge.anInt(), | |
| isLowRamDevice = forge.aBool() | |
| totalRam = forge.aNullable { anInt() }, | |
| isLowRamDevice = forge.aNullable { aBool() } |
Comment on lines
+399
to
+401
| processorCount = datadogContext.deviceInfo.processorCount, | ||
| totalRam = datadogContext.deviceInfo.totalRam, | ||
| isLowRamDevice = datadogContext.deviceInfo.isLowRamDevice |
Member
There was a problem hiding this comment.
we need to add assertions for these new properties in tests for RumViewScope, RumResourceScope, etc.
marco-saia-datadog
changed the title
totalRam, processorCount and isLowRamDevice to DeviceInfototalRam, processorCount and isLowRamDevice to DeviceInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds new attributes to the Device Info:
ActivityManager.isLowRamDevice)Additional Notes
Review checklist (to be filled by reviewers)