docs: Clarify NotReady state semantics for OpenFeature #3043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates FlagsClientState.NotReady documentation to clarify its usage: - Used before first setEvaluationContext() call (pre-initialization) - Used after client shutdown - Maps to OpenFeature's NOT_READY state Changes NoOpFlagsClient to return NotReady instead of Error(null) since a no-op client is not in an error state - it's simply not ready/available. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the semantics of
FlagsClientState.NotReadyto support OpenFeature integration.Changes
FlagsClientState.kt:
NoOpFlagsClient.kt:
Error(null)toNotReadyNoOpFlagsClientTest.kt:
Motivation
The OpenFeature spec defines NOT_READY as a valid pre-initialization and post-shutdown state,
not an error condition. These clarifications ensure FlagsClient state semantics align with
OpenFeature expectations.
Dependencies
This PR builds on PR #3042 (State management) and is required for PR #2998 (OpenFeature provider).
🤖 Generated with Claude Code