Rebuild profiling request for every profiling start #3076
+62
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prior to this PR, in
PerfettoProfilethe cancel signal and profiling request are created only when the class is initialized (not recreated if thestartis called for another time), which causes the following request can't be cancelled, because the original cancel signal is already cancelled before thus in a "cancelled" state.Motivation
This changes will be necessary to support multiple profiling request in the future.
Review checklist (to be filled by reviewers)