Skip to content

Conversation

@yugisu-flux
Copy link

@yugisu-flux yugisu-flux commented Dec 3, 2025

What does this PR do?

This PR updates the Flags SDK to evaluate feature flags synchronously. This is implemented by fetching all flags at the FlagsClient init stage (in the setEvaluationContext method)

  • Implement flag state sync on FlagsClient init
  • Add calls for tracking exposures & logging RUM events to sync methods
  • Remove async get*Details methods

Motivation

https://datadoghq.atlassian.net/browse/FFL-1460

Additional Notes

This PR is pending on PRs from iOS and Android SDK repositories:

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@yugisu-flux yugisu-flux self-assigned this Dec 3, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 3, 2025

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 4 Tests failed

    FlagsClient getBooleanDetails should fetch the boolean details from native side from packages/core/src/flags/__tests__/FlagsClient.test.ts (Fix with Cursor)

    FlagsClient getNumberDetails should fetch the number details from native side from packages/core/src/flags/__tests__/FlagsClient.test.ts (Fix with Cursor)

FlagsClient getObjectDetails should fetch the object details from native side from packages/core/src/flags/__tests__/FlagsClient.test.ts (Datadog) (Fix with Cursor)
Cannot read properties of undefined (reading 'test-object-flag')

    FlagsClient getStringDetails should fetch the string details from native side from packages/core/src/flags/__tests__/FlagsClient.test.ts (Fix with Cursor)

View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 62a43df | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Base automatically changed from dima/FFL-906-implement-flags-react-native-ios-wrapper to feature/flags December 9, 2025 17:16
…per' into dima/FFL-1460-sync-flag-evaluation-in-rn-sdk
@yugisu-flux yugisu-flux changed the base branch from feature/flags to dima/FFL-1256-implement-flags-react-native-android-wrapper December 9, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants