Skip to content

Conversation

@BridgeAR
Copy link
Collaborator

This allows to pick up runtime configuration changes in the future as well as allowing to simplify the code in future PRs. One possible change is to remove configure and to move the remote configuration to just update the singleton instead.

We can add events to activate and deactivate features as soon as updates are incoming that are not handled by a simple property access.

That way most configurations will be changeable at runtime as soon as the remote configuration handles all entries.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Overall package size

Self size: 13.19 MB
Deduped: 116.12 MB
No deduping: 131.13 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.82 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.207.0 | 201.39 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.15 | 106.53 kB | 424.55 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.0.1 | 78.45 kB | 78.45 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.81%. Comparing base (69661b4) to head (01c3c19).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6803      +/-   ##
==========================================
- Coverage   83.85%   83.81%   -0.05%     
==========================================
  Files         505      506       +1     
  Lines       21340    21350      +10     
==========================================
- Hits        17895    17894       -1     
- Misses       3445     3456      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official
Copy link

datadog-official bot commented Oct 30, 2025

⚠️ Tests

⚠️ Warnings

🧪 6 Tests failed

❄️ Known flaky: Plugin node:http/server canceled request should send traces to agent from canceled request (Datadog)
expected stub to not have been called

AssertionError: expected stub to not have been called
    at /home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-plugin-http/test/server.spec.js:69:43
    at handler (packages/dd-trace/test/plugins/agent.js:350:22)
    at /home/runner/work/dd-trace-js/dd-trace-js/packages/dd-trace/test/plugins/agent.js:226:7
    at Set.forEach (<anonymous>)
    at handleTraceRequest (packages/dd-trace/test/plugins/agent.js:222:17)
    at /home/runner/work/dd-trace-js/dd-trace-js/packages/dd-trace/test/plugins/agent.js:441:7
    at Layer.handleRequest (node_modules/router/lib/layer.js:152:17)
...
esm "after all" hook in "esm" from esm (Datadog)
Cannot read properties of undefined (reading 'remove')

TypeError: Cannot read properties of undefined (reading 'remove')
    at Context.<anonymous> (integration-tests/helpers/index.js:608:20)
    at process.processImmediate (node:internal/timers:483:21)
    at process.callbackTrampoline (node:internal/async_hooks:130:17)
esm "before all" hook in "esm" from esm (Datadog)
Cannot find module './preload-path/node-preload.js'
Require stack:
- /home/runner/work/dd-trace-js/dd-trace-js/node_modules/node-preload/process-node-options.js
- /home/runner/work/dd-trace-js/dd-trace-js/node_modules/node-preload/hook-spawn.js
- /home/runner/work/dd-trace-js/dd-trace-js/node_modules/node-preload/preload-path/node-preload.js
- internal/preload

Error: Cannot find module './preload-path/node-preload.js'
Require stack:
- /home/runner/work/dd-trace-js/dd-trace-js/node_modules/node-preload/process-node-options.js
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 01c3c19 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2025

Benchmarks

Benchmark execution time: 2025-11-07 01:08:50

Comparing candidate commit 01c3c19 in PR branch BridgeAR/2025-10-30-refactor-config-to-singleton-method with baseline commit 69661b4 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1601 metrics, 69 unstable metrics.

This allows to pick up runtime configuration changes in the future
as well as allowing to simplify the code in future PRs. One possible
change is to remove `configure` and to move the remote configuration
to just update the singleton instead.

We can add events to activate and deactivate features as soon as
updates are incoming that are not handled by a simple property access.

That way most configurations will be changeable at runtime as soon
as the remote configuration handles all entries.
@BridgeAR BridgeAR force-pushed the BridgeAR/2025-10-30-refactor-config-to-singleton-method branch from 3077408 to 411cae6 Compare November 7, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants