Skip to content

Conversation

@uurien
Copy link
Collaborator

@uurien uurien commented Nov 3, 2025

What does this PR do?

Fix stack traces when iast is enabled and application has --enable-source-maps

Motivation

Fix the bug

Plugin Checklist

Additional Notes

SCRS-1772

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Overall package size

Self size: 13.23 MB
Deduped: 116.13 MB
No deduping: 131.15 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.82 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.55 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.15 | 106.53 kB | 424.55 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.1 | 90.58 kB | 90.58 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.85%. Comparing base (80880d5) to head (6450553).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6828   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files         506      506           
  Lines       21371    21371           
=======================================
  Hits        17920    17920           
  Misses       3451     3451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

This comment has been minimized.

@pr-commenter
Copy link

pr-commenter bot commented Nov 3, 2025

Benchmarks

Benchmark execution time: 2025-11-13 10:41:59

Comparing candidate commit 6450553 in PR branch ugaitz/fix-iast-stacktraces-sourcemaps-enabled with baseline commit 80880d5 in branch master.

Found 2 performance improvements and 5 performance regressions! Performance is the same for 1592 metrics, 71 unstable metrics.

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18

  • 🟩 max_rss_usage [-16.224MB; -10.798MB] or [-11.551%; -7.688%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

  • 🟩 max_rss_usage [-16.615MB; -12.085MB] or [-11.839%; -8.612%]

scenario:appsec-iast-startup-time-iast-enabled-22

  • 🟥 max_rss_usage [+15.969MB; +21.968MB] or [+11.623%; +15.990%]

scenario:appsec-iast-startup-time-iast-enabled-24

  • 🟥 max_rss_usage [+8.665MB; +14.583MB] or [+6.107%; +10.278%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-22

  • 🟥 max_rss_usage [+9.658MB; +15.888MB] or [+7.169%; +11.793%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-24

  • 🟥 max_rss_usage [+15.328MB; +22.547MB] or [+11.673%; +17.170%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-22

  • 🟥 max_rss_usage [+7.642MB; +13.417MB] or [+5.773%; +10.135%]

@uurien uurien changed the title Use new translated methods for the vuln location fix[iast]: Use new translated methods for the vuln location Nov 6, 2025
@uurien uurien changed the title fix[iast]: Use new translated methods for the vuln location fix(iast): Fix stack traces when iast is enabled and application has --enable-source-maps Nov 13, 2025
@uurien uurien marked this pull request as ready for review November 13, 2025 10:51
@uurien uurien requested review from a team as code owners November 13, 2025 10:51
@uurien uurien merged commit ba308d4 into master Nov 13, 2025
779 checks passed
@uurien uurien deleted the ugaitz/fix-iast-stacktraces-sourcemaps-enabled branch November 13, 2025 13:24
dd-octo-sts bot pushed a commit that referenced this pull request Nov 13, 2025
@dd-octo-sts dd-octo-sts bot mentioned this pull request Nov 13, 2025
simon-id pushed a commit that referenced this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants