Skip to content

Conversation

@leoromanovsky
Copy link
Contributor

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Overall package size

Self size: 13.21 MB
Deduped: 116.84 MB
No deduping: 119.05 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.82 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.207.0 | 201.39 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 3, 2025

⚠️ Tests

⚠️ Warnings

🧪 7 Tests failed

    esbuild support for IAST cjs "before all" hook in "cjs" from cjs

ESM is built and runs as expected in a sandbox should build basic esm http server exporting cjs and create web traces at runtime from ESM is built and runs as expected in a sandbox (Datadog)
Command failed: node /tmp/0279b1e24dd6f5f4/67d53772c8ae42c4/esbuild/build.esm-http-output-cjs.mjs
✘ [ERROR] Could not resolve "@openfeature/server-sdk"

    node_modules/dd-trace/packages/dd-trace/src/openfeature/node-server/provider.js:4:60:
      4 │ ...EventEmitter, ProviderEvents } = require('@openfeature/server-sdk')
        ╵                                             ~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "@openfeature/server-sdk" as external to exclude it from the bundle, which will remove this error. You can also surround this "require" call with a try/catch block to handle this failure at run-time instead of bundle-time.

✘ [ERROR] Could not resolve "@openfeature/server-sdk"
...
ESM is built and runs as expected in a sandbox should build basic esm http server exporting esm and create web traces at runtime from ESM is built and runs as expected in a sandbox (Datadog)
Command failed: node /tmp/0279b1e24dd6f5f4/67d53772c8ae42c4/esbuild/build.esm-http-output-esm.mjs
✘ [ERROR] Could not resolve "@openfeature/server-sdk"

    node_modules/dd-trace/packages/dd-trace/src/openfeature/node-server/provider.js:4:60:
      4 │ ...EventEmitter, ProviderEvents } = require('@openfeature/server-sdk')
        ╵                                             ~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "@openfeature/server-sdk" as external to exclude it from the bundle, which will remove this error. You can also surround this "require" call with a try/catch block to handle this failure at run-time instead of bundle-time.

✘ [ERROR] Could not resolve "@openfeature/server-sdk"
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bdcfa84 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 3, 2025

Benchmarks

Benchmark execution time: 2025-11-03 22:21:48

Comparing candidate commit bdcfa84 in PR branch feature/embed-openfeature-evaluator with baseline commit 18f8a78 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 1597 metrics, 71 unstable metrics.

scenario:plugin-dns-control-24

  • 🟥 execution_time [+165.928ms; +323.519ms] or [+9.512%; +18.545%]

scenario:plugin-dns-with-tracer-24

  • 🟥 execution_time [+140.587ms; +297.860ms] or [+6.514%; +13.802%]

@leoromanovsky leoromanovsky force-pushed the feature/embed-openfeature-evaluator branch from 095a8b6 to bdcfa84 Compare November 3, 2025 22:12
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 13.46154% with 225 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.76%. Comparing base (18f8a78) to head (bdcfa84).
⚠️ Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
...s/dd-trace/src/openfeature/node-server/provider.js 6.55% 57 Missing ⚠️
...re/node-server/configuration/evaluateForSubject.js 8.62% 53 Missing ⚠️
...e/src/openfeature/flagging-core/cache/lru-cache.js 3.44% 28 Missing ⚠️
...d-trace/src/openfeature/node-server/rules/rules.js 8.69% 21 Missing ⚠️
...rc/openfeature/flagging-core/configuration/wire.js 7.14% 13 Missing ⚠️
...penfeature/node-server/configuration/evaluation.js 21.42% 11 Missing ⚠️
...e/flagging-core/cache/abstract-assignment-cache.js 9.09% 10 Missing ⚠️
...rc/openfeature/node-server/configuration/ufc-v1.js 10.00% 9 Missing ⚠️
...ature/flagging-core/configuration/exposureEvent.js 11.11% 8 Missing ⚠️
...ace/src/openfeature/node-server/shards/sharders.js 20.00% 8 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6830      +/-   ##
==========================================
- Coverage   83.62%   82.76%   -0.86%     
==========================================
  Files         506      523      +17     
  Lines       21373    21614     +241     
==========================================
+ Hits        17873    17889      +16     
- Misses       3500     3725     +225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants