Skip to content

Conversation

@bengl
Copy link
Collaborator

@bengl bengl commented Nov 4, 2025

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Overall package size

Self size: 13.19 MB
Deduped: 117.24 MB
No deduping: 119.45 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.82 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.207.0 | 201.39 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.13 | 106.46 kB | 424.36 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.58%. Comparing base (729d162) to head (656ccb8).

Files with missing lines Patch % Lines
packages/dd-trace/src/opentracing/span_context.js 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6842      +/-   ##
==========================================
- Coverage   83.60%   83.58%   -0.02%     
==========================================
  Files         506      506              
  Lines       21343    21338       -5     
==========================================
- Hits        17843    17835       -8     
- Misses       3500     3503       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 4, 2025

⚠️ Tests

⚠️ Warnings

🧪 224 Tests failed

tests.appsec.test_asm_standalone.Test_APISecurityStandalone.test_no_appsec_upstream__no_asm_event__is_kept_with_priority_1__from_0[express4] from system_tests_suite (Datadog)
AssertionError: assert False
 +  where False = assert_tags({'duration': 7686768, 'error': 0, 'meta': {'_dd.appsec.event_rules.version': '1.15.1', '_dd.appsec.fp.http.endpoint': ... 0.0, '_dd.appsec.enabled': 1.0, '_dd.appsec.rasp.duration': 31.709, '_dd.appsec.rasp.duration_ext': 54.662, ...}, ...}, {'duration': 7686768, 'error': 0, 'meta': {'_dd.appsec.event_rules.version': '1.15.1', '_dd.appsec.fp.http.endpoint': ... 0.0, '_dd.appsec.enabled': 1.0, '_dd.appsec.rasp.duration': 31.709, '_dd.appsec.rasp.duration_ext': 54.662, ...}, ...}, 'meta', {'_dd.p.other': '1', '_dd.p.ts': None})

self = <tests.appsec.test_asm_standalone.Test_APISecurityStandalone object at 0x7f0a99f82390>

    def test_no_appsec_upstream__no_asm_event__is_kept_with_priority_1__from_0(self):
        self.assert_product_is_enabled(self.check_r, self.tested_product)
        spans_checked = 0
        tested_meta: dict[str, str | Callable | None] = {self.propagated_tag(): None, "_dd.p.other": "1"}
        tested_metrics: dict[str, str | Callable | None] = {SAMPLING_PRIORITY_KEY: lambda x: x < 2}
...
tests.appsec.test_asm_standalone.Test_APISecurityStandalone.test_no_appsec_upstream__no_asm_event__is_kept_with_priority_1__from_0[express4-typescript] from system_tests_suite (Datadog)
AssertionError: assert False
 +  where False = assert_tags({'duration': 7938721, 'error': 0, 'meta': {'_dd.appsec.event_rules.version': '1.15.1', '_dd.appsec.fp.http.endpoint': ...: 0.0, '_dd.appsec.enabled': 1.0, '_dd.appsec.rasp.duration': 31.82, '_dd.appsec.rasp.duration_ext': 55.163, ...}, ...}, {'duration': 7938721, 'error': 0, 'meta': {'_dd.appsec.event_rules.version': '1.15.1', '_dd.appsec.fp.http.endpoint': ...: 0.0, '_dd.appsec.enabled': 1.0, '_dd.appsec.rasp.duration': 31.82, '_dd.appsec.rasp.duration_ext': 55.163, ...}, ...}, 'meta', {'_dd.p.other': '1', '_dd.p.ts': None})

self = <tests.appsec.test_asm_standalone.Test_APISecurityStandalone object at 0x7fbf683789e0>

    def test_no_appsec_upstream__no_asm_event__is_kept_with_priority_1__from_0(self):
        self.assert_product_is_enabled(self.check_r, self.tested_product)
        spans_checked = 0
        tested_meta: dict[str, str | Callable | None] = {self.propagated_tag(): None, "_dd.p.other": "1"}
        tested_metrics: dict[str, str | Callable | None] = {SAMPLING_PRIORITY_KEY: lambda x: x < 2}
...
tests.appsec.test_asm_standalone.Test_APISecurityStandalone.test_no_appsec_upstream__no_asm_event__is_kept_with_priority_1__from_0[express5] from system_tests_suite (Datadog)
AssertionError: assert False
 +  where False = assert_tags({'duration': 12017578, 'error': 0, 'meta': {'_dd.appsec.event_rules.version': '1.15.1', '_dd.appsec.fp.http.endpoint':... 0.0, '_dd.appsec.enabled': 1.0, '_dd.appsec.rasp.duration': 32.911, '_dd.appsec.rasp.duration_ext': 55.964, ...}, ...}, {'duration': 12017578, 'error': 0, 'meta': {'_dd.appsec.event_rules.version': '1.15.1', '_dd.appsec.fp.http.endpoint':... 0.0, '_dd.appsec.enabled': 1.0, '_dd.appsec.rasp.duration': 32.911, '_dd.appsec.rasp.duration_ext': 55.964, ...}, ...}, 'meta', {'_dd.p.other': '1', '_dd.p.ts': None})

self = <tests.appsec.test_asm_standalone.Test_APISecurityStandalone object at 0x7f79be09ff50>

    def test_no_appsec_upstream__no_asm_event__is_kept_with_priority_1__from_0(self):
        self.assert_product_is_enabled(self.check_r, self.tested_product)
        spans_checked = 0
        tested_meta: dict[str, str | Callable | None] = {self.propagated_tag(): None, "_dd.p.other": "1"}
        tested_metrics: dict[str, str | Callable | None] = {SAMPLING_PRIORITY_KEY: lambda x: x < 2}
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 656ccb8 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@bengl bengl force-pushed the bengl/de-format-2025 branch from 0326010 to 39b4b70 Compare November 4, 2025 21:10
@bengl bengl force-pushed the bengl/de-format-2025 branch from 39b4b70 to 656ccb8 Compare November 4, 2025 21:12
@pr-commenter
Copy link

pr-commenter bot commented Nov 4, 2025

Benchmarks

Benchmark execution time: 2025-11-04 21:22:35

Comparing candidate commit 656ccb8 in PR branch bengl/de-format-2025 with baseline commit 729d162 in branch master.

Found 13 performance improvements and 35 performance regressions! Performance is the same for 1561 metrics, 61 unstable metrics.

scenario:exporting-pipeline-0.4-18

  • 🟩 cpu_user_time [-19.240ms; -15.364ms] or [-7.594%; -6.064%]
  • 🟩 execution_time [-19.283ms; -15.692ms] or [-6.672%; -5.430%]

scenario:exporting-pipeline-0.4-22

  • 🟩 cpu_user_time [-18.970ms; -14.671ms] or [-8.426%; -6.517%]
  • 🟩 execution_time [-19.201ms; -15.497ms] or [-7.364%; -5.944%]

scenario:exporting-pipeline-0.4_with_stats-18

  • 🟩 cpu_user_time [-18.500ms; -15.328ms] or [-7.041%; -5.834%]

scenario:exporting-pipeline-0.5-18

  • 🟩 cpu_user_time [-17.502ms; -14.002ms] or [-8.091%; -6.473%]
  • 🟩 execution_time [-18.633ms; -15.868ms] or [-7.471%; -6.362%]

scenario:exporting-pipeline-0.5-22

  • 🟩 cpu_user_time [-13.192ms; -10.578ms] or [-7.738%; -6.204%]
  • 🟩 execution_time [-11.750ms; -10.207ms] or [-5.848%; -5.080%]

scenario:exporting-pipeline-0.5_with_stats-18

  • 🟩 cpu_user_time [-18.527ms; -15.322ms] or [-8.132%; -6.725%]
  • 🟩 execution_time [-18.342ms; -16.124ms] or [-6.997%; -6.151%]

scenario:exporting-pipeline-0.5_with_stats-22

  • 🟩 cpu_user_time [-12.706ms; -10.072ms] or [-6.744%; -5.346%]
  • 🟩 execution_time [-13.124ms; -11.522ms] or [-5.936%; -5.211%]

scenario:plugin-dns-with-tracer-20

  • 🟥 instructions [+54.8M instructions; +61.5M instructions] or [+5.240%; +5.875%]

scenario:plugin-dns-with-tracer-24

  • 🟥 cpu_user_time [+21.638ms; +40.653ms] or [+5.162%; +9.698%]
  • 🟥 instructions [+53.7M instructions; +59.6M instructions] or [+5.558%; +6.168%]

scenario:spans-finish-immediately-18

  • 🟥 cpu_user_time [+684.568ms; +692.911ms] or [+108.328%; +109.649%]
  • 🟥 execution_time [+788.949ms; +796.447ms] or [+114.977%; +116.069%]
  • 🟥 instructions [+1.7G instructions; +1.8G instructions] or [+74.933%; +75.643%]
  • 🟥 max_rss_usage [+74.255MB; +74.506MB] or [+105.232%; +105.588%]

scenario:spans-finish-immediately-20

  • 🟥 cpu_user_time [+652.607ms; +661.690ms] or [+118.169%; +119.814%]
  • 🟥 execution_time [+744.697ms; +753.084ms] or [+124.047%; +125.444%]
  • 🟥 instructions [+1.7G instructions; +1.8G instructions] or [+86.336%; +86.974%]
  • 🟥 max_rss_usage [+68.055MB; +68.248MB] or [+96.272%; +96.545%]

scenario:spans-finish-immediately-22

  • 🟥 cpu_user_time [+634.791ms; +643.468ms] or [+118.186%; +119.801%]
  • 🟥 execution_time [+690.553ms; +698.370ms] or [+116.464%; +117.782%]
  • 🟥 instructions [+1.8G instructions; +1.8G instructions] or [+86.604%; +87.494%]
  • 🟥 max_rss_usage [+78.923MB; +79.221MB] or [+101.909%; +102.294%]

scenario:spans-finish-immediately-24

  • 🟥 cpu_user_time [+542.772ms; +552.720ms] or [+109.859%; +111.872%]
  • 🟥 execution_time [+661.341ms; +669.554ms] or [+119.242%; +120.723%]
  • 🟥 instructions [+1.8G instructions; +1.8G instructions] or [+93.832%; +94.555%]
  • 🟥 max_rss_usage [+174.401MB; +174.779MB] or [+205.142%; +205.587%]

scenario:spans-finish-later-18

  • 🟥 cpu_user_time [+569.227ms; +644.503ms] or [+49.147%; +55.646%]
  • 🟥 execution_time [+652.595ms; +735.963ms] or [+49.165%; +55.445%]
  • 🟥 instructions [+1.9G instructions; +2.1G instructions] or [+58.823%; +66.869%]
  • 🟥 max_rss_usage [+80.485MB; +83.069MB] or [+33.945%; +35.035%]

scenario:spans-finish-later-20

  • 🟥 cpu_user_time [+459.111ms; +490.309ms] or [+43.902%; +46.885%]
  • 🟥 execution_time [+521.480ms; +553.891ms] or [+43.214%; +45.900%]
  • 🟥 instructions [+1.5G instructions; +1.5G instructions] or [+52.190%; +55.347%]
  • 🟥 max_rss_usage [+87.552MB; +88.699MB] or [+37.045%; +37.531%]

scenario:spans-finish-later-22

  • 🟥 cpu_user_time [+425.010ms; +443.693ms] or [+39.629%; +41.372%]
  • 🟥 execution_time [+505.644ms; +527.608ms] or [+40.964%; +42.743%]
  • 🟥 instructions [+1.6G instructions; +1.7G instructions] or [+50.482%; +53.321%]
  • 🟥 max_rss_usage [+91.688MB; +93.334MB] or [+38.048%; +38.731%]

scenario:spans-finish-later-24

  • 🟥 cpu_user_time [+467.091ms; +491.787ms] or [+49.618%; +52.242%]
  • 🟥 execution_time [+568.938ms; +600.693ms] or [+50.086%; +52.881%]
  • 🟥 instructions [+1.7G instructions; +1.8G instructions] or [+65.659%; +70.128%]
  • 🟥 max_rss_usage [+133.316MB; +149.729MB] or [+46.420%; +52.135%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants