swap out the existing headers normalization logic with the tag normalizer #5041
+15
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izer used for spans
|
👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md(possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None.(possible answers No/Nope/None) Visited at: 2025-11-12 16:20:11 UTC |
ivoanjo
reviewed
Nov 12, 2025
Comment on lines
28
to
40
| it 'preserves them' do | ||
| is_expected.to eq(tag) | ||
| is_expected.to eq("") | ||
| end | ||
| end | ||
|
|
||
| context 'with unsupported characters' do | ||
| let(:tag) { "\\ \t!@?" } | ||
|
|
||
| it 'replaces each with an underscore' do | ||
| is_expected.to eq('_' * tag.size) | ||
| # turns into an empty string because in a tag, the first character must be a letter | ||
| is_expected.to eq('') | ||
| end | ||
| end |
Member
There was a problem hiding this comment.
When changing the logic -- please update the test description as well! It'd be quite confusing to have a test saying "it replaces each with an underscore" that actually is not true :P
Collaborator
Author
There was a problem hiding this comment.
oh! good catch, I'll use a better description for this!
Collaborator
Author
There was a problem hiding this comment.
I updated the description but open to feedback on the wording !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the new tag normalization logic that was copied from the Trace Agent for headers.
Motivation:
While working on #5033, it was noticed that the current normalization logic in dd-trace-rb is missing some of the logic from https://github.com/DataDog/datadog-agent/blob/45799c842bbd216bcda208737f9f11cade6fdd95/pkg/trace/traceutil/normalize.go#L131 , specifically around:
_are mergedChange log entry
feat: swap out the existing headers normalization logic with the tag normalizer
Additional Notes:
I am not sure if we consider this to be a bug or a missing feature, but note that with this new logic, some of the headers results are going to be empty strings ie:
"", which can be seen in the tests below.How to test the change?
I've been using: