Skip to content

Conversation

Kr0nox
Copy link
Contributor

@Kr0nox Kr0nox commented Aug 19, 2025

No description provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maven is not added
The directory needs to be set to the folder, the dependency managing file is in, see:
https://github.com/jplag/JPlag/blob/c895e28a48a23bc44b8bef4c0edd1e43cabc174c/.github/dependabot.yml#L28-L31

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should find a better name than main

@01Parzival10
Copy link
Collaborator

@Kr0nox can you take another look at it. I can't add you as a reviewer

Copy link
Contributor Author

@Kr0nox Kr0nox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the dependabot.yml you still have the directory set to the root, but it should the place where the dependecies are defined, so /Frontend and /Backend

labels:
- "dependencies"
- package-ecosystem: "maven"
target-branch: "develop"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you target develop not main

Copy link
Contributor Author

@Kr0nox Kr0nox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@01Parzival10 01Parzival10 merged commit adae719 into main Sep 2, 2025
4 checks passed
@01Parzival10 01Parzival10 deleted the workflows branch September 2, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants