-
Notifications
You must be signed in to change notification settings - Fork 1
Add Workflows #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maven is not added
The directory needs to be set to the folder, the dependency managing file is in, see:
https://github.com/jplag/JPlag/blob/c895e28a48a23bc44b8bef4c0edd1e43cabc174c/.github/dependabot.yml#L28-L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should find a better name than main
@Kr0nox can you take another look at it. I can't add you as a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the dependabot.yml you still have the directory
set to the root, but it should the place where the dependecies are defined, so /Frontend
and /Backend
.github/dependabot.yml
Outdated
labels: | ||
- "dependencies" | ||
- package-ecosystem: "maven" | ||
target-branch: "develop" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you target develop not main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.