Skip to content

Migrate Zebra auth integration to daylily-auth-cognito#62

Merged
iamh2o merged 1 commit intomainfrom
codex/zebra-auth-cognito-prep
Apr 7, 2026
Merged

Migrate Zebra auth integration to daylily-auth-cognito#62
iamh2o merged 1 commit intomainfrom
codex/zebra-auth-cognito-prep

Conversation

@iamh2o
Copy link
Copy Markdown
Contributor

@iamh2o iamh2o commented Apr 7, 2026

Summary

  • switch Zebra's Cognito integration to daylily-auth-cognito 2.0 surfaces
  • update auth/web/observability tests and docs for the new package boundary
  • keep the current local auth-domain refactor mergeable before the CLI v2 rollout starts

Validation

  • /Users/jmajor/projects/daylily/zebra_day/.venv-prep-zebra312/bin/python -m pytest tests/test_auth.py tests/test_modern_web.py tests/test_observability_contract.py tests/test_deploy_contract.py -q

@iamh2o iamh2o merged commit 55e3533 into main Apr 7, 2026
5 of 12 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d65844380d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +430 to +431
tokens = asyncio.run(
cognito_session.exchange_authorization_code_async(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid nested event loops in exchange_code

Calling asyncio.run(...) here will raise RuntimeError whenever exchange_code is invoked from an already-running event loop (for example, from an async FastAPI handler or async integration code), so the OAuth code exchange path can fail at runtime even with valid Cognito inputs. The previous implementation was loop-agnostic because it used a synchronous exchange function; this should either be made async end-to-end or use an event-loop-safe bridge.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant