Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b94d38064
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @tapdb_app.command("db") | ||
| def db_passthrough( | ||
| args: list[str] = _PASSTHROUGH_ARGS, |
There was a problem hiding this comment.
These passthrough handlers dropped the parser settings that previously enabled forwarding arbitrary tapdb flags. Click defaults to ignore_unknown_options=False and allow_extra_args=False, which means option-like tokens are treated as parser errors instead of leftovers for passthrough, so calls such as zday tapdb db ... --schema ... can fail before db_passthrough executes. This regresses the wrapper contract of delegating raw arguments to the external tapdb CLI.
Useful? React with 👍 / 👎.
| @cognito_app.command("daycog") | ||
| def daycog_passthrough( | ||
| args: list[str] = _PASSTHROUGH_ARGS, |
There was a problem hiding this comment.
The daycog passthrough command now parses arguments without unknown-option forwarding, so option-style arguments intended for daycog may be rejected by the CLI parser before reaching _run_daycog. Click’s default behavior is to error on unknown options unless ignore_unknown_options/allow_extra_args passthrough settings are enabled, so common invocations that rely on downstream flags can break despite this command being documented as raw pass-through.
Useful? React with 👍 / 👎.
1 participant
Summary
cli-core-yo==2.0.0with local TapDB and Daycog repo wiring--no-auth, JSON handling, and migrated command registrationValidation
python -m compileall zebra_day/cli zebra_day/settings.pypython -m pytest -q tests/test_deploy_contract.py tests/test_cli.py tests/test_gui_cli.py tests/test_cli_registry_v2.py tests/test_cli_extended.pypython -m ruff check zebra_day testspython -m buildzday --help,zday --json version, JSON rejection on non-JSON commands, runtime failure onprinter listwithout conda env, and migrated subgroup help/status paths