Skip to content

Show package name in derivation inventories#51

Closed
cole-h wants to merge 1 commit intomainfrom
cole-h/push-spxzppkzmmzs
Closed

Show package name in derivation inventories#51
cole-h wants to merge 1 commit intomainfrom
cole-h/push-spxzppkzmmzs

Conversation

@cole-h
Copy link
Member

@cole-h cole-h commented Feb 26, 2026

Summary by CodeRabbit

  • Chores
    • Updated build configuration to include package names in derivation metadata.

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c464b0 and 77b1d70.

📒 Files selected for processing (1)
  • flake.nix

📝 Walkthrough

Walkthrough

A single line in flake.nix is modified within the lib.derivationsInventory section to compute the what field as a string that includes both the existing what value and the package name, rather than inheriting the existing value directly.

Changes

Cohort / File(s) Summary
Nix Configuration
flake.nix
Modified the what field computation in derivation entries to include package name via string interpolation: "${what} '${package.name}'" instead of inheriting the existing value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through derivations bright,
Adding names to each in sight,
What was once plain, now shows its face,
Package identity finds its place! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: showing package names in derivation inventories by modifying how the 'what' field is computed in flake.nix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cole-h/push-spxzppkzmmzs

Comment @coderabbitai help to get the list of available commands and usage tips.

@cole-h cole-h closed this Feb 26, 2026
@cole-h cole-h deleted the cole-h/push-spxzppkzmmzs branch February 26, 2026 17:38
@cole-h
Copy link
Member Author

cole-h commented Feb 26, 2026

(Discussed briefly: we probably want to make nix flake show show this, but through the C++ rather than through changing the what so that it can stay as "just" what exactly it is: it's e.g. a package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant