-
Notifications
You must be signed in to change notification settings - Fork 0
Push ynlmnrwpxkql #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
0788f79
cef5f57
29b4392
dc8b25c
f671601
d20aaee
e591766
6e93642
77d4d45
82f9104
3933314
da97c1c
f97eb8f
1ad8088
2111385
033f2f8
5ee1512
4a0338d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ export interface HeaderProps { | |
|
|
||
| const Header: FC<HeaderProps> = ({ logo, elements = [] }) => { | ||
| return ( | ||
| <header className="header" role="banner"> | ||
| <div className="header"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Restore semantic landmark: use (banner).Switching the root to a div loses the banner landmark. Use the semantic element (role optional). - <div className="header">
+ <header className="header" role="banner">
...
- </div>
+ </header>Also applies to: 25-25 🤖 Prompt for AI Agents |
||
| <div className="header__container"> | ||
| {!!logo && <div className="header__logo">{logo}</div>} | ||
|
|
||
|
|
@@ -22,7 +22,7 @@ const Header: FC<HeaderProps> = ({ logo, elements = [] }) => { | |
| </div> | ||
| )} | ||
| </div> | ||
| </header> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Make kind optional for backward compatibility
You already default kind to "snippet"; let callers omit it.
Also ensure the exported type mirrors this change.
Also applies to: 24-33
🏁 Script executed:
Length of output: 83
🏁 Script executed:
Length of output: 455
🏁 Script executed:
Length of output: 5026
Make CodeBlockProps.kind optional
Align the exported type with the component default and existing call sites.
Edit: src/CodeBlock/index.tsx (interface CodeBlockProps — kind at ~line 18). src/index.ts re-exports the type — no change needed.
📝 Committable suggestion
🤖 Prompt for AI Agents