-
Notifications
You must be signed in to change notification settings - Fork 656
Appointment Form Redesign: Common Layout changes after designer review #31506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sjbur
wants to merge
22
commits into
DevExpress:25_2
Choose a base branch
from
sjbur:v2_2682_25_2
base: 25_2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
aa95fe4
style: fix week buttons container size
sjbur e9a5102
fix: fix css errors
sjbur 792197b
feat: change paddings
sjbur a2c5206
fix: fix tests
sjbur 2ceb85f
fix: fix test
sjbur 3dc60bb
Merge branch '25_2' into v2_2682_25_2
sjbur 005ea18
fix: revert changes
sjbur 67cb581
fix: revert css button fixed sizing
sjbur 5093159
feat: update etalons
sjbur 6563ad4
Revert "fix: revert css button fixed sizing"
sjbur 953abbf
css: make fixed sizing for generic theme weekday buttons
sjbur c3e3d8b
Merge branch '25_2' into v2_2682_25_2
sjbur 55d2265
Merge branch '25_2' into v2_2682_25_2
sjbur cb276d2
Merge branch '25_2' into v2_2682_25_2
sjbur 376b8b2
fix: make settings button auto only in fluent
sjbur 3d1c6ed
fix: fix settings button display in material theme
sjbur 73bc271
css: try to fix group overlapping
sjbur 7a91fc9
css: fix styles
sjbur 582d53a
css: update styles
sjbur 652e2c6
css: fix repeat every icon position
sjbur 2ad87e1
css: fix lint errors
sjbur 0a212cb
Merge branch '25_2' into v2_2682_25_2
sjbur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+0 Bytes
(100%)
...etalons/scheduler__recurrence-form__daily__repeat-end-count (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-316 Bytes
(98%)
...etalons/scheduler__recurrence-form__daily__repeat-end-never (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2 Bytes
(100%)
...etalons/scheduler__recurrence-form__daily__repeat-end-until (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+23 Bytes
(100%)
...ntForm/etalons/scheduler__recurrence-form__editing-existing (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
.../appointmentForm/etalons/scheduler__recurrence-form__hourly (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
...mentForm/etalons/scheduler__recurrence-form__monthly__day-1 (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
...entForm/etalons/scheduler__recurrence-form__monthly__day-15 (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+23 Bytes
(100%)
...Form/etalons/scheduler__recurrence-form__weekly__interval-2 (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+23 Bytes
(100%)
...Form/etalons/scheduler__recurrence-form__weekly__interval-5 (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+23 Bytes
(100%)
...orm/etalons/scheduler__recurrence-form__weekly__mon-wed-fri (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+23 Bytes
(100%)
...entForm/etalons/scheduler__recurrence-form__weekly__weekend (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...mentForm/etalons/scheduler__recurrence-form__yearly__dec-31 (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...tmentForm/etalons/scheduler__recurrence-form__yearly__jan-1 (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
packages/devextreme-scss/scss/widgets/generic/scheduler/_sizes.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| @use "../sizes" as *; | ||
| @use "../button/colors" as *; | ||
| @use "../toolbar/sizes" as *; | ||
|
|
||
| // adduse | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Extra blank line at end of file. The file should end with a single newline after the closing brace on line 988.