bxdf fixes: non cook-torrance stuff #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

devshgraphicsprogramming merged 24 commits into master from bxdf_fixes_non_ct

Sep 19, 2025

Contributor

keptsecret commented Sep 2, 2025

No description provided.

keptsecret added 13 commits

September 1, 2025 15:25


          minor fixes to interaction, microfacet cache in common.hlsl

4fd9d59


          added delta distribution bxdfs

3c4a1d5


          added oren nayar bsdf

1eac170


          fixes to smooth dielectric bsdf

be844a5


          redone bxdf concepts

5f9f746


          don't take sample u by reference

349d6b2


          added a reflectTransmit to ray dir type

5b6bb6e


          fix thin dielectric scatter func

4f31580


          Merge branch 'master' into bxdf_fixes_non_ct

e2357fc


          Merge branch 'master' into bxdf_fixes_non_ct

3d418bb


          change microfacet bxdf concept

34ae295


          Merge branch 'master' into bxdf_fixes_non_ct

906d3ec


          Merge branch 'master' into bxdf_fixes_non_ct

1099d60

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/reflection/lambertian.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/smooth_dielectric.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/smooth_dielectric.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/common.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/common.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/common.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/common.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/common.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/reflection/delta_distribution.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/reflection/delta_distribution.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/delta_distribution.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/delta_distribution.hlsl Outdated Show resolved Hide resolved

keptsecret added 6 commits

September 18, 2025 13:51


          Merge branch 'master' into bxdf_fixes_non_ct

c194f4e


          minor oren nayar changes to store A2 and AB

d80f5ca


          Merge branch 'master' into bxdf_fixes_non_ct

5dd4956


          minor fixes to concept, iso cachce

d4c61bd


          removed create from lambertian, delta dis bc they do nothing

68c8123


          added macro for bxdf type aliases

a0dbcc2

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/common.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/oren_nayar.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/reflection/delta_distribution.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/reflection/delta_distribution.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/delta_distribution.hlsl Outdated Show resolved Hide resolved

keptsecret added 3 commits

September 19, 2025 15:30


          oren nayar create changes

b0c41f7


          fix more oren nayar bugs

7e086f4


          fix delta distribution generate

6488ba4

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/reflection/oren_nayar.hlsl Outdated Show resolved Hide resolved

keptsecret added 2 commits

September 19, 2025 16:00


          reverted __rec_pi_factored_out_wo_clamps removal in oren nayar

75ef607


          moved lambertian and oren nayar logic into a base class

906d437

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/base/lambertian.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/base/oren_nayar.hlsl Show resolved Hide resolved

devshgraphicsprogramming merged commit fb76cec into master

19 of 20 checks passed

devshgraphicsprogramming deleted the bxdf_fixes_non_ct branch

September 19, 2025 13:38

devshgraphicsprogramming mentioned this pull request

Bxdf fixes cook torrance #930

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet