-
Notifications
You must be signed in to change notification settings - Fork 0
Fix helm login #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix helm login #242
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
=======================================
Coverage 76.09% 76.09%
=======================================
Files 13 13
Lines 1945 1945
=======================================
Hits 1480 1480
Misses 465 465 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably shouldn't actually approve until the install passes
And pin the version of helm being used to prevent future changes breaking workflows.
9c86d29 to
82ba0b2
Compare
|
Bit awkward that you can't pin to a major version. Is it better to pin to a specific patch version or deal with any changes that happen with the latest version? |
DominicOram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit awkward that you can't pin to a major version. Is it better to pin to a specific patch version or deal with any changes that happen with the latest version?
My opinion tends to be to never pin and just fix things when they break. Otherwise, in my experience, you end up pinned to 1.X still when 8.X comes out, which has changes that you really need, and the job of moving them is horrible. However, that only works when you notice that the new version is failing, which we didn't here or on the config server so approving for now
And pin the version of helm being used to prevent future changes
breaking workflows.