Skip to content

Conversation

@tpoliaw
Copy link
Collaborator

@tpoliaw tpoliaw commented Jan 8, 2026

And pin the version of helm being used to prevent future changes
breaking workflows.

@tpoliaw tpoliaw requested a review from DominicOram January 8, 2026 17:52
@tpoliaw tpoliaw linked an issue Jan 8, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.09%. Comparing base (f42c3df) to head (82ba0b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   76.09%   76.09%           
=======================================
  Files          13       13           
  Lines        1945     1945           
=======================================
  Hits         1480     1480           
  Misses        465      465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't actually approve until the install passes

And pin the version of helm being used to prevent future changes
breaking workflows.
@tpoliaw tpoliaw force-pushed the helm_action_version branch from 9c86d29 to 82ba0b2 Compare January 9, 2026 10:22
@tpoliaw
Copy link
Collaborator Author

tpoliaw commented Jan 9, 2026

Bit awkward that you can't pin to a major version. Is it better to pin to a specific patch version or deal with any changes that happen with the latest version?

@tpoliaw tpoliaw requested a review from DominicOram January 9, 2026 10:32
Copy link

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit awkward that you can't pin to a major version. Is it better to pin to a specific patch version or deal with any changes that happen with the latest version?

My opinion tends to be to never pin and just fix things when they break. Otherwise, in my experience, you end up pinned to 1.X still when 8.X comes out, which has changes that you really need, and the job of moving them is horrible. However, that only works when you notice that the new version is failing, which we didn't here or on the config server so approving for now

@tpoliaw tpoliaw merged commit 215775d into main Jan 9, 2026
7 checks passed
@tpoliaw tpoliaw deleted the helm_action_version branch January 9, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart failing to be pushed

3 participants