Skip to content

Debuggable shaders #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Debuggable shaders #721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faccbe8
debuggable shaders in when compiled in debug
Poohl Nov 14, 2025
4ce0c89
Formatting
Poohl Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions Graphics/ShaderTools/src/GLSLangUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ EShLanguage ShaderTypeToShLanguage(SHADER_TYPE ShaderType)
static_assert(SHADER_TYPE_LAST == 0x4000, "Please handle the new shader type in the switch below");
switch (ShaderType)
{
// clang-format off
// clang-format off
case SHADER_TYPE_VERTEX: return EShLangVertex;
case SHADER_TYPE_HULL: return EShLangTessControl;
case SHADER_TYPE_DOMAIN: return EShLangTessEvaluation;
Expand Down Expand Up @@ -266,6 +266,9 @@ std::vector<unsigned int> CompileShaderInternal(::glslang::TShader& Sh
Shader.setAutoMapBindings(true);
Shader.setAutoMapLocations(true);
TBuiltInResource Resources = InitResources();
#ifdef DILIGENT_DEBUG
messages = static_cast<EShMessages>(static_cast<unsigned>(messages) | static_cast<unsigned>(EShMessages::EShMsgDebugInfo));
#endif

bool ParseResult = pIncluder != nullptr ?
Shader.parse(&Resources, 100, shProfile, false, false, messages, *pIncluder) :
Expand All @@ -288,8 +291,17 @@ std::vector<unsigned int> CompileShaderInternal(::glslang::TShader& Sh
if (AssignBindings)
Program.mapIO();

::glslang::SpvOptions spvOptions;
#ifdef DILIGENT_DEBUG
spvOptions.generateDebugInfo = true;
# if DILIGENT_NO_HLSL
// will be stripped anyway with HLSL support anyway
spvOptions.emitNonSemanticShaderDebugInfo = true;
spvOptions.emitNonSemanticShaderDebugSource = true;
# endif
#endif
std::vector<unsigned int> spirv;
::glslang::GlslangToSpv(*Program.getIntermediate(Shader.getStage()), spirv);
::glslang::GlslangToSpv(*Program.getIntermediate(Shader.getStage()), spirv, &spvOptions);

return spirv;
}
Expand Down Expand Up @@ -409,7 +421,7 @@ spv_target_env SpirvVersionToSpvTargetEnv(SpirvVersion Version)
static_assert(static_cast<int>(SpirvVersion::Count) == 6, "Did you add a new member to SpirvVersion? You may need to handle it here.");
switch (Version)
{
// clang-format off
// clang-format off
case SpirvVersion::Vk100: return SPV_ENV_VULKAN_1_0;
case SpirvVersion::Vk110: return SPV_ENV_VULKAN_1_1;
case SpirvVersion::Vk110_Spirv14: return SPV_ENV_VULKAN_1_1_SPIRV_1_4;
Expand Down