Skip to content

Edited Publish and Remove Buttons to use POST requests #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Edited Publish and Remove Buttons to use POST requests #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions en/homework/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,14 @@ into these:
<div class="date">
{{ post.published_date }}
</div>

{% else %}
<aside class="actions">
<a class="btn btn-secondary" role="button" href="{% url 'post_publish' pk=post.pk %}">Publish</a>
<form method="post" action="{% url 'post_publish' pk=post.pk %}" style="display: inline;">
{% csrf_token %}
<button type="submit" class="btn btn-secondary">Publish</button>
</form>
</aside>
{% endif %}
{% endif %}
```

As you noticed, we added {% raw %}`{% else %}`{% endraw %} line here. That means, that if the condition from {% raw %}`{% if post.published_date %}`{% endraw %} is not fulfilled (so if there is no `published_date`), then we want to do the lines with `<form ... </form>`. But wait -- why are we bothering with a form here? There are no fields to fill in. Why are we not creating the publish button using an `<a class="btn">` element like we did before?
Expand All @@ -112,7 +114,7 @@ def post_publish(request, pk):
post = get_object_or_404(Post, pk=pk)
if request.method=='POST':
post.publish()
return redirect('post_detail', pk=pk)
return redirect('post_draft_list')
```

Note that we check the request method before executing the operation -- although the pages we will emit will not include a direct link to the URL of this view, and so one could think this check is redundant, in practice this sort of "defensive programming" often pays off, preventing damage which could have been caused by bugs.
Expand All @@ -138,9 +140,13 @@ Congratulations! You are almost there. The last step is adding a delete button!
Let's open `blog/templates/blog/post_detail.html` once again and add these lines:

```django
<a class="btn btn-secondary" href="{% url 'post_remove' pk=post.pk %}">
{% include './icons/trash-fill.svg' %}
</a>
<form method="post" action="{% url 'post_remove' pk=post.pk %}" style="display: inline;">
{% csrf_token %}
<button type="submit" class="btn btn-secondary"
onclick="return confirm('Are you sure you want to delete this post?')">
{% include './icons/trash-fill.svg' %}
</button>
</form>
```

just under a line with the edit button.
Expand Down