Conversation
| - **INNGEST_EVENTS_RECEIVED_AFTER** (optional) - An RFC3339 timestamp to filter events received after a specific date (e.g., `2024-01-01T00:00:00Z`). If unset, no date filter is applied. | ||
|
|
||
| - **INNGEST_JOBS_MAX_EVENTS** (optional) - Maximum number of events to fetch when listing jobs. Default is 100, maximum is 10000. Used for pagination with cursor. |
There was a problem hiding this comment.
Phantom environment variables with incorrect defaults
INNGEST_EVENTS_RECEIVED_AFTER and INNGEST_JOBS_MAX_EVENTS do not exist anywhere in the codebase. There are no reads from process.env.INNGEST_EVENTS_RECEIVED_AFTER or process.env.INNGEST_JOBS_MAX_EVENTS in apps/api/src/service.ts or any other file. Additionally, the documented default of 100 for INNGEST_JOBS_MAX_EVENTS is incorrect — the actual hardcoded constant in service.ts is DEFAULT_MAX_EVENTS = 500.
Documenting non-existent environment variables will confuse users who try to configure them and wonder why they have no effect. These entries should either be removed or, if they are intended to be added in a follow-up, the code should actually read from process.env.
| ### Docker Configuration | ||
|
|
||
| Optional configuration for customizing Docker daemon connections: | ||
|
|
||
| - **DOCKER_API_VERSION** (optional) - Specifies which Docker API version to use when connecting to the Docker daemon. If not set, the Docker client uses the default API version. | ||
|
|
||
| - **DOCKER_HOST** (optional) - Specifies the Docker daemon host to connect to. If not set, uses the default Docker socket connection. | ||
|
|
||
| - **DOCKER_PORT** (optional) - Specifies the port for connecting to the Docker daemon. If not set, uses the default port. | ||
|
|
||
| These variables allow advanced users to customize how the Dokploy API server connects to Docker, which can be useful for connecting to remote Docker daemons or using specific API versions. |
There was a problem hiding this comment.
Docker configuration variables are not used by this API server
DOCKER_API_VERSION, DOCKER_HOST, and DOCKER_PORT are consumed by packages/server/src/constants/index.ts (the main Dokploy server package), not by the apps/api server. The apps/api source files (index.ts, service.ts, utils.ts, schema.ts) contain zero references to Docker or these environment variables.
Documenting them here implies they affect the behavior of apps/api, which is misleading. This section should either be removed from this README or moved to the documentation for the package that actually reads these variables.
| ## Search Endpoints | ||
|
|
||
| The following search endpoints provide flexible querying capabilities with pagination support. All search endpoints respect member permissions, returning only resources the user has access to. | ||
|
|
There was a problem hiding this comment.
Search endpoints belong to the main Dokploy app, not this API server
application.search, compose.search, environment.search, project.search, and the database service search procedures are tRPC procedures defined in apps/dokploy/server/api/routers/*.ts. They are served by the main Next.js application, not by apps/api.
The apps/api HTTP server only exposes: POST /deploy, POST /cancel-deployment, GET /health, GET /jobs, and GET|POST|PUT /api/inngest. Adding a large "Search Endpoints" section here will mislead users into looking for these endpoints on the wrong server.
| - All searches use case-insensitive pattern matching with wildcards | ||
| - Results are ordered by creation date (descending) | ||
| - Members only see services they have access to | ||
| - Returns total count for pagination UI No newline at end of file |
There was a problem hiding this comment.
Missing newline at end of file
The file does not end with a newline character. This is a minor formatting issue but is typically flagged by linters and can cause noisy diffs in future changes.
| - Returns total count for pagination UI | |
| - Returns total count for pagination UI | |
| + Returns total count for pagination UI |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Update documentation for #3894
Generated by Dosu
Greptile Summary
This auto-generated documentation PR updates
CONTRIBUTING.mdandapps/api/README.md. While the intent is good, theapps/api/README.mdadditions contain three critical factual errors:Key issues:
INNGEST_EVENTS_RECEIVED_AFTERandINNGEST_JOBS_MAX_EVENTSdo not exist in the codebase. The documented default of 100 forINNGEST_JOBS_MAX_EVENTSis incorrect; the actual hardcoded constant is 500.DOCKER_API_VERSION,DOCKER_HOST, andDOCKER_PORTare consumed bypackages/server/src/constants/index.ts, notapps/api. Documenting them here misleads users.application.search,compose.search,environment.search,project.search, and database service search endpoints are tRPC procedures from the main Dokploy app (apps/dokploy/server/api/routers), not REST endpoints exposed byapps/api. The API server only exposes:POST /deploy,POST /cancel-deployment,GET /health,GET /jobs, andGET|POST|PUT /api/inngest.The
CONTRIBUTING.mdchanges are accurate, but the API README issues must be resolved before merging.Confidence Score: 1/5
apps/api/README.mdcontains three distinct factual errors: phantom environment variables with incorrect defaults, incorrect ownership of Docker configuration variables, and search endpoints documented under the wrong service. These inaccuracies in developer-facing documentation can cause real confusion and wasted debugging time. TheCONTRIBUTING.mdadditions are fine, but the overall PR quality is low due to the README issues.Last reviewed commit: 0c5d49c
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!