Hatch boundaries non linear scaling boundaries#1008
Open
Mikolaj505 wants to merge 2 commits intoDomCR:masterfrom
Open
Hatch boundaries non linear scaling boundaries#1008Mikolaj505 wants to merge 2 commits intoDomCR:masterfrom
Mikolaj505 wants to merge 2 commits intoDomCR:masterfrom
Conversation
Owner
|
Hi @Mikolaj505, This change is not needed for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both Hatch.BoundaryPath.Arc and Hatch.BoundaryPart.Ellipse was not handling non-linear scaling when ApplyingTransform. I think the most proper way should be like in this PR -> reconstrucing Ellipse / Arc from points, after applying the non uniform scales.
It clearer words, when applying a scale (1.5, 2, 2) to a circle, one cannot just scale the radius by some value. The circle would change it's shape. Similiar here.