Add curl timeout and retry flags to prevent install script hangs#517
Add curl timeout and retry flags to prevent install script hangs#517enescakir wants to merge 1 commit intoDopplerHQ:masterfrom
Conversation
|
+1 This would be very helpful for us. We regularly run into ETIMEDOUT errors, making CI fail. |
|
Hey @enescakir, I've reviewed and tested this and this all looks good. Could you please remove claude as a co-author for the commit? Once that's done, I'll approve this and get it merged. Thanks! |
Thanks @amoses12, I'll remove it. I have one more question. My main motivation for changing it was to improve the robustness of the Since the action has a 30 seconds timeout, using However, using a much shorter |
The curl command in curl_download() had no connect-timeout or max-time set, causing it to hang indefinitely on slow/stalled connections. The --retry 5 flag was ineffective because curl never timed out on its own to trigger a retry. Added: - --connect-timeout 10: fail fast if server is unreachable - --max-time 60: cap total transfer time per attempt - --retry-all-errors: retry on all errors, not just transient ones
6b22f74 to
1bc8808
Compare
The curl command in curl_download() had no connect-timeout or max-time set, causing it to hang indefinitely on slow/stalled connections. The --retry 5 flag was ineffective because curl never timed out on its own to trigger a retry.
The
dopplerhq/cli-actionaction has 30 seconds timeout, so it occasionally fails without retry.Added: