Skip to content

Add translation to ID validation pattern#1321

Merged
joshunrau merged 2 commits intoDouglasNeuroInformatics:mainfrom
david-roper:adjust-age-limit
Mar 25, 2026
Merged

Add translation to ID validation pattern#1321
joshunrau merged 2 commits intoDouglasNeuroInformatics:mainfrom
david-roper:adjust-age-limit

Conversation

@david-roper
Copy link
Copy Markdown
Collaborator

@david-roper david-roper commented Mar 25, 2026

closes issue #1320

Summary by CodeRabbit

  • Chores
    • Updated French form label text to properly reflect the field's validation requirements.

@david-roper david-roper self-assigned this Mar 25, 2026
@david-roper david-roper requested a review from joshunrau as a code owner March 25, 2026 20:48
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

Walkthrough

Updated a French label text for an identity validation form field from a placeholder value to a meaningful string ("Modèle de validation d'identité") in a single file. No logic, validation, or behavior changes.

Changes

Cohort / File(s) Summary
French Label Update
apps/web/src/routes/_app/group/manage.tsx
Updated the idValidationRegex form field label from "TBD" placeholder to French text "Modèle de validation d'identité". No functional or behavioral changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding a French translation for the ID validation pattern label in the form field.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
apps/web/src/routes/_app/group/manage.tsx (1)

144-144: Consider using "identifiant" or "ID" instead of "identité" for consistency.

The word "identité" means "identity" (the concept), while this field validates ID/identifier strings. Line 139 uses "identifiants" and line 81 uses "l'ID" for similar concepts. Consider:

  • "Modèle de validation d'identifiant" or
  • "Modèle de validation d'ID"
📝 Suggested translation adjustment
-                fr: "Modèle de validation d'identité"
+                fr: "Modèle de validation d'identifiant"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/routes/_app/group/manage.tsx` at line 144, Replace the French
label string "Modèle de validation d'identité" with a term consistent with other
labels (use either "Modèle de validation d'identifiant" or "Modèle de validation
d'ID") in the translations/labels block in
apps/web/src/routes/_app/group/manage.tsx; locate the exact entry where fr:
"Modèle de validation d'identité" is defined and update it to match the project
convention used elsewhere (see nearby entries referencing "identifiants" and
"l'ID").
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/web/src/routes/_app/group/manage.tsx`:
- Line 144: Replace the French label string "Modèle de validation d'identité"
with a term consistent with other labels (use either "Modèle de validation
d'identifiant" or "Modèle de validation d'ID") in the translations/labels block
in apps/web/src/routes/_app/group/manage.tsx; locate the exact entry where fr:
"Modèle de validation d'identité" is defined and update it to match the project
convention used elsewhere (see nearby entries referencing "identifiants" and
"l'ID").

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 86c2d189-8e46-420d-a3e2-60d8c328d250

📥 Commits

Reviewing files that changed from the base of the PR and between b31b635 and 4236bed.

📒 Files selected for processing (1)
  • apps/web/src/routes/_app/group/manage.tsx

@joshunrau joshunrau merged commit 7b90b70 into DouglasNeuroInformatics:main Mar 25, 2026
2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants