Skip to content

fix some minor styling issues with DataTable#89

Merged
joshunrau merged 4 commits intomainfrom
data-table-grouped-style
Mar 23, 2026
Merged

fix some minor styling issues with DataTable#89
joshunrau merged 4 commits intomainfrom
data-table-grouped-style

Conversation

@joshunrau
Copy link
Collaborator

@joshunrau joshunrau commented Mar 23, 2026

Summary by CodeRabbit

  • New Features

    • Added "Modify" and "Delete" row actions to data tables with dedicated action handlers.
  • Style & Layout

    • Updated cell background styling for improved visual consistency.
    • Refined header border alignment for action columns.
    • Disabled column resizing in grouped column configurations.

@joshunrau joshunrau merged commit 20514f9 into main Mar 23, 2026
1 check passed
@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 529cf52e-167a-4b58-93d3-6a99d49bfd62

📥 Commits

Reviewing files that changed from the base of the PR and between 1101afb and a4c2aa2.

📒 Files selected for processing (3)
  • src/components/DataTable/DataTable.stories.tsx
  • src/components/DataTable/DataTableBody.tsx
  • src/components/DataTable/DataTableHead.tsx

Walkthrough

DataTable component refinements: story configuration adds row actions and disables column resizing for grouped sub-columns, cell wrapper styling applies background inheritance, and border removal logic now targets adjacent actions columns explicitly rather than positional "center last column" checks.

Changes

Cohort / File(s) Summary
Story Configuration
src/components/DataTable/DataTable.stories.tsx
Adds rowActions array with "Modify" and "Delete" actions to Grouped story; disables column resizing (enableResizing: false) for grouped sub-columns.
Cell Styling
src/components/DataTable/DataTableBody.tsx
Adds bg-inherit class to table cell wrapper divs; reformats JSX across multiple lines.
Border Logic
src/components/DataTable/DataTableHead.tsx
Imports ACTIONS_COLUMN_ID and changes right-border removal from positional "last center column" check to column-id-based detection of adjacent actions column.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🎨 Tables dressed in inherited hues,
Actions columns aligned with new clues,
Resize toggles tamed, row actions bloom—
DataTable refinement has cleared the room. ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch data-table-grouped-style

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

🎉 This PR is included in version 6.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant