label Profile music player with track title and artist #1895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On the Profile screen, the music player that users add to their profiles had no label for screen readers, so nothing meaningful was announced.
Change
In ProfileActivity (profile adapter, VIEW_TYPE_MUSIC case), after setMusicDocument(...) a two-line contentDescription is set:
•
Line 1: existing Music string
•
Line 2: existing AccDescrMusicInfo(artist, title) format (same as chats), with fallbacks to AudioUnknownArtist and AudioUnknownTitle when empty.
Result
Screen readers now announce “Music” followed by “{artist}, {title}”. If no saved music is present, the label is cleared to avoid incorrect announcements.
Scope
Only ProfileActivity.java; no new strings; no visual/behavioral changes for sighted users.
Testing
demo_for_added_label_to_music_of_profile.mp4
Built and verified with TalkBack; a profile with saved music is announced with the expected title and artist.